Skip to content

Revert "Ensure the identity name is the same for C# and VB templates(#946)" #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jun 18, 2019
Merged

Revert "Ensure the identity name is the same for C# and VB templates(#946)" #993

1 commit merged into from
Jun 18, 2019

Conversation

@vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Jun 18, 2019 •
edited
Loading

This reverts Revert "Ensure the identity name is the same for C# and VB templates(#946)"; commit cf0bed3

Fixes #987
This could regress AB#902637, FYI @jmarolf

/cc @peterhuene, @livarcocc

@vatsan-madhavan
Reverts "Ensure the identity name is the same for C# and VB templates (…
36705d7 
…#946)"

This reverts commit cf0bed3.

Fixes ‘Dotnet new‘ shows WPF template for VB only #987
@ghost ghost requested review from rladuca, ryalanms and stevenbrix June 18, 2019 00:27
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 18, 2019
@vatsan-madhavan vatsan-madhavan added the auto_merge bot-command label Jun 18, 2019
@ghost
Copy link

ghost commented Jun 18, 2019

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 18, 2019

@msftbot, require at least 1 sign off.

@ghost
Copy link

ghost commented Jun 18, 2019

@msftbot, require approvals from any one of the following: @vatsan-madhavan, @rladuca, @SamBent, @stevenbrix, @ryalanms

@ghost ghost merged commit c9bdfc0 into master Jun 18, 2019
@ghost ghost deleted the dev/vatsan/proj-template-issue987 branch June 18, 2019 01:16
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryalanms ryalanms ryalanms approved these changes

@rladuca rladuca Awaiting requested review from rladuca

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees

No one assigned

Labels

auto_merge bot-command PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

‘Dotnet new‘ shows WPF template for VB only

3 participants

@vatsan-madhavan @ryalanms