Skip to content

feat(Chart): add ShowTotalDataLabel parameter#8216

Merged
ArgoZhang merged 6 commits into
mainfrom
dev-8192
Jul 11, 2026
Merged

feat(Chart): add ShowTotalDataLabel parameter#8216
ArgoZhang merged 6 commits into
mainfrom
dev-8192

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Jul 11, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8192

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add a new bar chart demo showcasing stacked total data labels.

New Features:

  • Introduce a bar chart sample that displays total data labels for stacked datasets.

Enhancements:

  • Extend chart configuration options to support showing total data labels in stacked bar charts.

Documentation:

  • Update localized demo text for the new stacked total data label bar chart example.

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 11, 2026
@bb-auto bb-auto Bot added this to the v10.8.0 milestone Jul 11, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds support and a demo for showing total data labels on stacked bar charts, including a new chart initialization method, a corresponding demo block, and localized text entries.

Sequence diagram for stacked bar chart total data label demo

sequenceDiagram
    actor User
    participant BarPage
    participant Chart
    participant BarCodeBehind
    participant ChartDataSource

    User->>BarPage: Navigate to BarTotalDataLabel demo
    BarPage->>Chart: Render Chart ChartType.Bar OnInitAsync=OnInitTotalDataLabel
    Chart->>BarCodeBehind: OnInitTotalDataLabel()
    BarCodeBehind->>ChartDataSource: create ChartDataSource
    BarCodeBehind->>ChartDataSource: set Options.ShowDataLabel = true
    BarCodeBehind->>ChartDataSource: set Options.ShowTotalDataLabel = true
    BarCodeBehind-->>Chart: return ChartDataSource
    Chart-->>User: Display stacked bar chart with total data labels
Loading

File-Level Changes

Change Details Files
Add a new stacked bar chart configuration that enables both individual and total data labels.
  • Introduce OnInitTotalDataLabel method that constructs a ChartDataSource for a stacked bar chart.
  • Configure chart options to show data labels, show total data labels, center the labels, and stack both X and Y axes.
  • Populate labels and datasets to demonstrate totals across multiple series.
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor.cs
Expose the new total data label chart configuration in the bar chart demo page.
  • Add a new DemoBlock for the total data label example wired to OnInitTotalDataLabel.
  • Reference localized title and introduction strings for the new demo block.
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor
Provide localization and any supporting project configuration for the new bar chart total data label demo.
  • Add or update en-US localization entries for the new bar chart total data label title and introduction.
  • Add or update zh-CN localization entries for the new bar chart total data label title and introduction.
  • Adjust project configuration if needed to include or update localization resources.
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#8192 Add a boolean parameter to stacked bar charts (e.g., ShowTotalDataLabel) that, when enabled, displays the total value above each stacked bar.
#8192 Expose and demonstrate the new total-above-bar option in the bar chart samples and related localization/docs so users can see and use the feature.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

bb-auto[bot]
bb-auto Bot previously approved these changes Jul 11, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new OnInitTotalDataLabel setup largely duplicates the stacked bar configuration; consider extracting a shared helper for common stacked options to keep these demos easier to maintain.
  • The chart title "Stacked total" in OnInitTotalDataLabel is hard-coded while other text is localized; consider aligning this with the localization approach used elsewhere in the Bar chart samples.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `OnInitTotalDataLabel` setup largely duplicates the stacked bar configuration; consider extracting a shared helper for common stacked options to keep these demos easier to maintain.
- The chart title "Stacked total" in `OnInitTotalDataLabel` is hard-coded while other text is localized; consider aligning this with the localization approach used elsewhere in the Bar chart samples.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1557d5d) to head (5af6049).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          769       769           
  Lines        34427     34427           
=========================================
  Hits         34427     34427           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

bb-auto[bot]
bb-auto Bot previously approved these changes Jul 11, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit d661903 into main Jul 11, 2026
7 checks passed
@ArgoZhang
ArgoZhang deleted the dev-8192 branch July 11, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Bar Chart): Show the total number above each bar in a stacked bar chart

1 participant