Conversation
Contributor
Reviewer's GuideAdds support and a demo for showing total data labels on stacked bar charts, including a new chart initialization method, a corresponding demo block, and localized text entries. Sequence diagram for stacked bar chart total data label demosequenceDiagram
actor User
participant BarPage
participant Chart
participant BarCodeBehind
participant ChartDataSource
User->>BarPage: Navigate to BarTotalDataLabel demo
BarPage->>Chart: Render Chart ChartType.Bar OnInitAsync=OnInitTotalDataLabel
Chart->>BarCodeBehind: OnInitTotalDataLabel()
BarCodeBehind->>ChartDataSource: create ChartDataSource
BarCodeBehind->>ChartDataSource: set Options.ShowDataLabel = true
BarCodeBehind->>ChartDataSource: set Options.ShowTotalDataLabel = true
BarCodeBehind-->>Chart: return ChartDataSource
Chart-->>User: Display stacked bar chart with total data labels
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
OnInitTotalDataLabelsetup largely duplicates the stacked bar configuration; consider extracting a shared helper for common stacked options to keep these demos easier to maintain. - The chart title "Stacked total" in
OnInitTotalDataLabelis hard-coded while other text is localized; consider aligning this with the localization approach used elsewhere in the Bar chart samples.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `OnInitTotalDataLabel` setup largely duplicates the stacked bar configuration; consider extracting a shared helper for common stacked options to keep these demos easier to maintain.
- The chart title "Stacked total" in `OnInitTotalDataLabel` is hard-coded while other text is localized; consider aligning this with the localization approach used elsewhere in the Bar chart samples.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 769 769
Lines 34427 34427
=========================================
Hits 34427 34427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8192
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new bar chart demo showcasing stacked total data labels.
New Features:
Enhancements:
Documentation: