Skip to content

doc(Chart): add center sample code#8219

Merged
ArgoZhang merged 2 commits into
mainfrom
dev-8191
Jul 11, 2026
Merged

doc(Chart): add center sample code#8219
ArgoZhang merged 2 commits into
mainfrom
dev-8191

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Jul 11, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8191

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Demonstrate stacked bar chart data labels anchored at both the end and center within the sample page.

New Features:

  • Add a stacked bar chart sample showcasing data labels anchored at the center alongside the existing end-anchored variant.

Enhancements:

  • Update the stacked data label demo layout to display two side-by-side charts with adjusted dimensions for better comparison of label anchoring.

@sourcery-ai

sourcery-ai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Bar chart demo to showcase data label anchoring (center vs end) and wires the sample to a parameterized initialization method, along with corresponding localization entries.

Sequence diagram for Bar chart stacked data label center vs end demo

sequenceDiagram
    actor User
    participant BarComponent
    participant Chart_end
    participant Chart_center
    participant OnInitStackedShowDataLabel

    User->>BarComponent: navigate BarStackedShowDataLabel demo
    BarComponent->>Chart_end: render Chart ChartType.Bar
    BarComponent->>Chart_center: render Chart ChartType.Bar

    Chart_end->>OnInitStackedShowDataLabel: OnInitStackedShowDataLabel(false)
    OnInitStackedShowDataLabel-->>Chart_end: ChartDataSource (Title Anchor_End)

    Chart_center->>OnInitStackedShowDataLabel: OnInitStackedShowDataLabel(true)
    OnInitStackedShowDataLabel-->>Chart_center: ChartDataSource (Title Anchor_Center, Anchor=Center)
Loading

File-Level Changes

Change Details Files
Update stacked bar chart demo layout to show two side-by-side charts comparing different data label anchors.
  • Replace single Chart instance with a Bootstrap row containing two responsive columns.
  • Instantiate two Chart components configured with different OnInitAsync lambdas, each targeting a different anchor setting.
  • Adjust chart dimensions to fit side-by-side layout in the demo block.
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor
Extend stacked bar chart initialization logic to support configurable data label anchoring and titles.
  • Change OnInitStackedShowDataLabel to accept a boolean parameter indicating whether to use center anchoring.
  • Set chart title dynamically based on the anchor mode (center vs end).
  • Conditionally assign ChartDataLabelPosition.Center to Options.Anchor when center mode is enabled.
  • Keep existing stacked axis and data label configuration while adding anchor support.
src/BootstrapBlazor.Server/Components/Samples/Charts/Bar.razor.cs
Add or update localization strings for the new/adjusted Bar chart demo text related to data label anchoring.
  • Introduce or modify English locale entries to describe the center vs end data label anchor sample.
  • Introduce or modify Chinese locale entries to match the new demo wording.
  • Ensure localization keys align with usage in the Bar chart demo components.
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#8191 Implement support for displaying each stacked bar segment's value centered within the segment (e.g., via a ChartOptions.Anchor = Center-style configuration) in the chart component itself. The PR only updates the sample Bar chart demo to show two charts, one with Anchor: Center and one with Anchor: End, by adding a center parameter to the demo's OnInitStackedShowDataLabel method and setting ds.Options.Anchor = ChartDataLabelPosition.Center when center is true. It does not introduce or modify any core chart component behavior or configuration options; it assumes the centering capability already exists.
#8191 Provide an optional parameter or configuration to control whether bar segment values are shown or not (i.e., toggle data label visibility) as part of the feature. The PR relies on the existing ds.Options.ShowDataLabel = true setting in the demo code and does not add a new optional parameter or API to control label visibility. It only adjusts how the existing labels are anchored in the demo, without adding a toggle mechanism at the component or options level.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 11, 2026
@bb-auto bb-auto Bot added this to the v10.8.0 milestone Jul 11, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang ArgoZhang merged commit d9269e9 into main Jul 11, 2026
5 checks passed
@ArgoZhang ArgoZhang deleted the dev-8191 branch July 11, 2026 07:24

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider replacing the bool center parameter on OnInitStackedShowDataLabel with a more descriptive enum or using ChartDataLabelPosition directly to avoid ambiguous boolean flags and make the intent clearer at call sites.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider replacing the `bool center` parameter on `OnInitStackedShowDataLabel` with a more descriptive enum or using `ChartDataLabelPosition` directly to avoid ambiguous boolean flags and make the intent clearer at call sites.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d661903) to head (3356a7b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          769       769           
  Lines        34427     34427           
=========================================
  Hits         34427     34427           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Bar Chart): Center the segment value in a stacked bar chart, instead of at the top of the bar segment.

1 participant