Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Bar chart demo to showcase data label anchoring (center vs end) and wires the sample to a parameterized initialization method, along with corresponding localization entries. Sequence diagram for Bar chart stacked data label center vs end demosequenceDiagram
actor User
participant BarComponent
participant Chart_end
participant Chart_center
participant OnInitStackedShowDataLabel
User->>BarComponent: navigate BarStackedShowDataLabel demo
BarComponent->>Chart_end: render Chart ChartType.Bar
BarComponent->>Chart_center: render Chart ChartType.Bar
Chart_end->>OnInitStackedShowDataLabel: OnInitStackedShowDataLabel(false)
OnInitStackedShowDataLabel-->>Chart_end: ChartDataSource (Title Anchor_End)
Chart_center->>OnInitStackedShowDataLabel: OnInitStackedShowDataLabel(true)
OnInitStackedShowDataLabel-->>Chart_center: ChartDataSource (Title Anchor_Center, Anchor=Center)
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider replacing the
bool centerparameter onOnInitStackedShowDataLabelwith a more descriptive enum or usingChartDataLabelPositiondirectly to avoid ambiguous boolean flags and make the intent clearer at call sites.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider replacing the `bool center` parameter on `OnInitStackedShowDataLabel` with a more descriptive enum or using `ChartDataLabelPosition` directly to avoid ambiguous boolean flags and make the intent clearer at call sites.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8219 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 769 769
Lines 34427 34427
=========================================
Hits 34427 34427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8191
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Demonstrate stacked bar chart data labels anchored at both the end and center within the sample page.
New Features:
Enhancements: