Skip to content

feat(TreeView): add IsIncludeIndeterminateWhenGetCheckedItems parameter - #8451

Merged
ArgoZhang merged 1 commit into
mainfrom
dev-tv-check
Sep 11, 2026
Merged

feat(TreeView): add IsIncludeIndeterminateWhenGetCheckedItems parameter#8451
ArgoZhang merged 1 commit into
mainfrom
dev-tv-check

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Sep 11, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8450

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Allow TreeView consumers to control whether indeterminate nodes are returned as checked items.

New Features:

  • Add a TreeView parameter that optionally includes indeterminate nodes in the collection returned by GetCheckedItems().

Tests:

  • Add coverage verifying GetCheckedItems() behavior with and without indeterminate nodes.

@sourcery-ai

sourcery-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds an opt-in TreeView parameter that makes GetCheckedItems() include indeterminate nodes, preserves the existing checked-only default, and validates both modes with an AutoCheckParent tri-state unit test.

File-Level Changes

Change Details Files
Adds a configurable TreeView option controlling whether indeterminate nodes are returned by GetCheckedItems().
  • Introduces the IsIncludeIndeterminateWhenGetCheckedItems component parameter with a default of false and bilingual documentation.
  • Refactors checked-item filtering to include both checked and indeterminate states when the option is enabled, while preserving checked-only behavior by default.
src/BootstrapBlazor/Components/TreeView/TreeView.razor.cs
Adds coverage for the new filtering behavior in tri-state checkbox scenarios.
  • Verifies the default excludes the indeterminate parent node.
  • Verifies enabling the parameter includes both the indeterminate parent and checked child.
test/UnitTest/Components/TreeViewTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8450 Add an IsIncludeIndeterminateWhenGetCheckedItems parameter to TreeView.
#8450 Make GetCheckedItems() optionally include indeterminate nodes when the new parameter is enabled, while preserving the existing behavior by default.
#8450 Provide automated test coverage for the new parameter and its default behavior.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Sep 11, 2026
@bb-auto bb-auto Bot added this to the v10.10.0 milestone Sep 11, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (43a563f) to head (328c148).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          776       776           
  Lines        35067     35069    +2     
=========================================
+ Hits         35067     35069    +2     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang
ArgoZhang merged commit 5df9f52 into main Sep 11, 2026
6 checks passed
@ArgoZhang
ArgoZhang deleted the dev-tv-check branch September 11, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(TreeView): add IsIncludeIndeterminateWhenGetCheckedItems parameter

1 participant