chore(release): v0.8.0 "Breadth" — Phase 7 - #196
Conversation
Cuts the Phase 7 release. Both cut criteria from to-dos/VERSION-PLAN.md are met and were verified rather than assumed: - The battery reports a real pass rate: 54 probes, 100%, across two Angrylion oracle suites (41 RDP rasteriser vectors + 13 VI scan-out vectors). - Every residual R-1 through R-23 carries a ledger disposition, and no residual is referenced anywhere in docs/ or to-dos/ without a ledger entry. The headline is that commercial cartridges render. Super Mario 64 draws its title screen and 29 of 66 staged titles render through their own graphics microcode. Both defects that unblocked that were in the CPU and the PIF, not the RDP where R-18 had been looking: - an interrupt taken across an ERET was charged to the ERET, overwriting EPC with the ERET's own address and livelocking the CPU (#189); - the PIF answered as a connected controller on all four joybus channels, so osContInit reported four pads on a one-pad console and Super Mario 64 halted in its own assert (#190). T-71-003 -- the one cut criterion CI can never run, because F3DEX ships inside ROMs ADR 0008 forbids committing -- closes on a committed local census plus 14 viewed screenshots, recorded in VERSION-PLAN as the single documented exception rather than an unstated weakening of the gate. Version bumped 0.7.0 -> 0.8.0 across the workspace and all path dependencies; CHANGELOG [Unreleased] cut to [0.8.0]; STATUS records Phase 7 complete and the release history through v0.8.0. Pre-release gate: clean tree, version consistent (Cargo == CHANGELOG), no stale 0.7.0 in manifests, v0.8.0 tag free, no ROMs staged, no conflict markers, CHANGELOG entry present, no_std build green. Plus fmt, clippy -D warnings, cargo test --workspace, rustdoc -D warnings, markdownlint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workspace and RustyN64 crates are bumped to v0.8.0. Changelog and status documentation identify “Breadth” as the current release and record Phase 7 accuracy-battery results, Super Mario 64 title-screen rendering status, and release automation coverage. ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 19-20: Update the release-note sentence in CHANGELOG.md by
replacing “Both defects that unblocked that were” with “Both defects that
unblocked it were”, leaving the surrounding wording unchanged.
- Around line 9-20: Keep the v0.8.0 release claims consistent with tag creation:
in CHANGELOG.md lines 9-20, place the entry under [Unreleased] until the tagged
release commit; in docs/STATUS.md lines 6-15, describe v0.8.0 as pending; in
docs/STATUS.md line 139, remove the claim that v0.8.0 is tagged and released;
and in docs/STATUS.md lines 316-318, keep the exercised release range ending at
the latest existing tag.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 05f35c2d-77a8-4031-abe0-f6f8620e931e
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock,!Cargo.lock
📒 Files selected for processing (14)
CHANGELOG.mdCargo.tomlcrates/rustyn64-audio/Cargo.tomlcrates/rustyn64-cart/Cargo.tomlcrates/rustyn64-cheevos/Cargo.tomlcrates/rustyn64-core/Cargo.tomlcrates/rustyn64-cpu/Cargo.tomlcrates/rustyn64-frontend/Cargo.tomlcrates/rustyn64-netplay/Cargo.tomlcrates/rustyn64-rdp/Cargo.tomlcrates/rustyn64-rsp/Cargo.tomlcrates/rustyn64-snapshot/Cargo.tomlcrates/rustyn64-test-harness/Cargo.tomldocs/STATUS.md
Adopts a CodeRabbit wording fix in the v0.8.0 release note. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adjudication — review roundCI 13/13 (release PRs run the full matrix plus Wording: "unblocked that" → "unblocked it" — adoptedFixed. "Do not claim a v0.8.0 release before the tag exists" — rejected: the wording already says exactly thatThis is the standard release-commit pattern in this repo, and the text is explicit about the ordering rather than glossing it:
Identical phrasing to the v0.7.0 release commit, verified with
The alternative — keeping the entry under "Retain an empty
|
Antigravity review (Gemini via Ultra)This pull request performs the Blocking issuesNone found. SuggestionsNone found. This is a mechanical release version bump; workspace crate dependencies and documentation were updated consistently. NitpicksNone. Automated first-pass review by |
Cuts the Phase 7 release. Both cut criteria from
to-dos/VERSION-PLAN.mdare met, and were verified rather than assumed:docs/orto-dos/without oneThe headline: commercial cartridges render
Super Mario 64 draws its title screen, and 29 of 66 staged titles render through their own graphics microcode. Fourteen frames are committed under
screenshots/, every one rendered and looked at.Both defects that unblocked this were in the CPU and the PIF — not the RDP, where R-18 had been looking for months:
ERETwas charged to theERET, overwritingEPCwith theERET's own address and livelocking the CPU.osContInitreported four pads on a one-pad console and SM64 halted in its own assert.Both oracle-validated: n64-systemtest Phase 1
Failed: 0, suite-wide 90, unchanged throughout.T-71-003 — the one non-CI gate
F3DEX ships inside commercial ROMs that ADR 0008 forbids committing, so this criterion can never be CI-gated. Per the maintainer decision it closes on a committed local census (
microcode_families.rs,#[ignore]d, skips loudly) plus the screenshots — recorded inVERSION-PLAN.mdas the single documented exception, not an unstated weakening of the gate.Pre-release gate
Plus fmt · clippy
-D warnings·cargo test --workspace· rustdoc-D warnings· markdownlint.Explicitly NOT claimed
v0.8.0 is a phase close, not the end of the plan. Still open and tracked: 24 titles issue zero RDP commands (each a separate root-cause hunt — they halt, they are not stalled), the mirrored-text defect (
mirror_scleared by oracle; negativeDsDxand triangle winding remain), the ledger-extraction refactor, and 1080's IPL3 fault. Those are v0.9.0 "Threshold" material by the release plan's own definition.