feat: v1.5.0 Workstream C — TASVideos pass + replay/TAS polish + NSF waveform scope

[doublegate]

v1.5.0 "Lens" — Workstream C: creator / TAS / speedrun tooling (beta.2)

All additive / off-by-default. Replay stays bit-identical, AccuracyCoin 100% (139/139) holds, and the shipped / native / no_std / wasm builds are byte-identical to beta.1 for non-test paths.

C1 — TASVideos / extended emulator-test pass

Audited RustyNES against the Nesdev "Emulator tests" + "Tricky-to-emulate games" indices and the christopherpow/nes-test-roms aggregator for committable tests beyond the 139 AccuracyCoin battery.

• mmc3_test v1 (6 sub-ROMs, blargg/kevtris PD) wired into tests/mmc3.rs (distinct ROMs from the already-wired mmc3_test_2, same $6000 protocol):
  • 1/2/3 strict-PASS.
  • 4/5/6 expected-fail — pinned as documented #[ignore]'d strict tests + _currently_fails shape-probes. They converge on the same ADR-0002 fractional-master-clock scanline-IRQ-cadence residual as the existing mmc3_test_2/4 chore(ci): Bump softprops/action-gh-release from 1 to 2 #3 (4-scanline chore(ci): Bump softprops/action-gh-release from 1 to 2 #3 "IRQ sooner when $2000=$08"; 5-MMC3 chore(ci): Bump actions/checkout from 4 to 6 #2 + 6-MMC6 chore(ci): Bump actions/checkout from 4 to 6 #2 "reload-to-0 IRQ cadence"). No new bug — sub-scanline IRQ cadence, deferred to v2.0 (do-not-grind directive honored).
• dpcmletterbox (Damian Yerrick, royalty-free) added as a deterministic framebuffer-hash visual smoke (tests/tasvideos_extended.rs) — a DMC-IRQ-as-scanline-timer raster split with no mapper IRQ, so a sensitive DMC-IRQ + sprite-0 + NMI/DMC-phase sentinel.
• Not committed (licensing unclear): scanline-a1, tvpassfail, etc. — stay in the gitignored local corpus.
• tests/roms/LICENSES.md + docs/testing-strategy.md updated.

C2 — Replay / TAS window polish

Tools → Replay / TAS — a dedicated control + read-out surface (per GeraNES ReplayWindowUI):

• device-topology read-out (per-port controller/peripheral + Four Score),
• timebase read-out (region + whole-Hz estimate + elapsed/total wall-clock),
• Record / Play / Branch / Stop controls (mirror F6/F7/F8) + deterministic seek-to-frame (slider + Start / −10 / +1 / +10).

Frontend-only over the existing MovieUi / rustynes_core::Movie machinery. The app pushes a read-only ReplayInfo snapshot each frame and drains a ReplayRequest after the egui pass. Seek re-derives state (MovieUi::seek_playback = seek_to_start + replay recorded inputs) — proven bit-identical to linear playback by seek_is_bit_identical_to_linear_playback. No new determinism surface.

C3 — NSF waveform visualizer

A per-channel oscilloscope (pulse 1/2, triangle, noise, DMC) in the NSF Player window, fed from the read-only apu_snapshot() DAC levels; surfaces the expansion-audio chip name (VRC6/VRC7/FME-7/N163/MMC5/FDS) when present. Output-only eye-candy — samples a copy for display, no synthesis change.

Gates (all green)

• cargo test --workspace --features test-roms — AccuracyCoin 139/139 (RAM 100.00%) + mapper honesty gate + the new C1 suites + all determinism-sensitive suites.
• cargo clippy --workspace --all-targets -- -D warnings + --features scripting,hd-pack + --features retroachievements + both wasm flavours.
• cargo fmt --all --check · RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps · no_std thumbv7em · markdownlint v0.39.0.
• Frontend lib tests (incl. new C2 seek + C3 scope + replay-panel tests) pass.

Do not merge — for maintainer review.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[gemini-code-assist]

Code Review

This pull request implements the v1.5.0 'Lens' Workstream C, introducing creator, TAS, and speedrun tooling. Key additions include a dedicated Replay / TAS window with device topology, timebase, and deterministic seek-to-frame controls, alongside a per-channel oscilloscope waveform visualizer in the NSF Player window. The test suite is also expanded with the older mmc3_test v1 suite and the dpcmletterbox visual regression test. Feedback on these changes identifies a bug where the seek slider fails to track the live cursor during playback, and a performance regression in the NSF panel where a closure unnecessarily allocates strings on every frame.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.