Use consistent language and punctuation on application pages.#687
Merged
sarahwalters merged 1 commit intodoubleunion:mainfrom Jul 20, 2022
Merged
Use consistent language and punctuation on application pages.#687sarahwalters merged 1 commit intodoubleunion:mainfrom
sarahwalters merged 1 commit intodoubleunion:mainfrom
Conversation
* On the application edit page, the "required" marking on fields is not enclosed in parentheses, but the "(optional)" marking is in parentheses. This PR changes "required" to "(required)" for consistency. * On the application show page, not all fields are marked as "required" or "optional". This PR marks all of the fields. * The explanation for why we ask for pronouns is phrased differently on the edit and show pages. This PR updates the two pages to use the same language.
anaulin
approved these changes
Jul 18, 2022
Contributor
anaulin
left a comment
anaulin
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! 🧹
| %td= markdown(@user.profile.attendance) No newline at end of file | ||
| %td.left | ||
| Have you been to DU events or met DU members? | ||
| %small (required) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Cleanup in the files that the change for #487 touches.
What does this code do, and why?
How is this code tested?
Locally -- only text changes
Are any database migrations required by this change?
No
Are there any configuration or environment changes needed?
No
Screenshots please :)
Before:
Edit page:
Show page:
After:
Edit page:
Show page:
