Move block of social media links to the bottom of the application form.#713
Merged
Move block of social media links to the bottom of the application form.#713
Conversation
As suggested in #562. I also removed the nested-table style from the stylesheet for this page. It was only used for the table that contains the checkboxes at the end of the form. I think the table with the checkboxes actually looks slightly better without this style.
anaulin
approved these changes
Aug 14, 2022
Contributor
anaulin
left a comment
anaulin
left a comment
There was a problem hiding this comment.
A high-ROI change, looks like. Thank you! 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
#562
What does this code do, and why?
Move the block of social media links in the application form to the bottom of the form, as suggested in #562.
I also removed the nested-table style from the stylesheet for this page. It was only used for the nested table that contains the checkboxes at the end of the form. I think the nested table with the checkboxes looks slightly better without this style (the checkboxes are better aligned with the other form items -- see screenshots). Additionally, the new nested table for the social media links does not look good with the nested-table style, and it would be confusing to have a nested-table style that is used for one of these nested tables but not the other.
How is this code tested?
Locally -- UI changes only.
Are any database migrations required by this change?
No
Are there any configuration or environment changes needed?
No
Screenshots please :)
Before:
Social media links at the top of the application:
Checkboxes at the end of the application, with the nested-table style (note that the checkboxes start further left than the other application questions):
After:
Social media links at the end of the application, and checkboxes without the nested-table style (note that the checkboxes are aligned with the other application questions):
