Conversation
As suggested in github.com//issues/562. * The preview feature is confusing since it only works if you save the application before previewing it. This PR removes the preview functionality. * The explanatory text about markdown is confusing. This PR removes it. * The intro text does not explain application visibility clearly. This PR updates it.
anaulin
approved these changes
Aug 15, 2022
Contributor
anaulin
left a comment
anaulin
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up! 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
#562
What does this code do, and why?
As suggested in issue #562, this PR:
How is this code tested?
Locally -- only UI changes.
Are any database migrations required by this change?
No
Are there any configuration or environment changes needed?
No
Screenshots please :)
Unsubmitted application:
Top of page (preview link and text about markdown removed; application visibility clarified):
Bottom of page (preview link removed):
Submitted application:
Once an application is submitted, you can still use "View application" to see how the application will look to voting members. This behavior existed before and I did not remove it. We can remove it if it's confusing / not useful.
"View application" takes you to this page:
