fix: pin patched ModelExpress in frontend workspace - #35
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures the standalone lib/bindings/python Cargo workspace (used by the frontend image’s maturin build) applies the same patched ModelExpress crates as the repository root, so the Rust extension no longer builds against the crates.io modelexpress-* 0.3.0 release.
Changes:
- Add
[patch.crates-io]overrides inlib/bindings/python/Cargo.tomlformodelexpress-clientandmodelexpress-common, pinned torushilbhat/modelexpress@46e4633a…. - Update
lib/bindings/python/Cargo.lockso both ModelExpress crates resolve from the pinned git source (and capture the resulting transitive resolution).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/bindings/python/Cargo.toml | Mirrors root workspace patches by pinning modelexpress-client/common to the patched git revision. |
| lib/bindings/python/Cargo.lock | Records the new git-sourced resolution for the ModelExpress crates and updated transitive dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
104
to
+108
| [patch.crates-io] | ||
| llm-multimodal = { git = "https://github.com/lightseekorg/smg", rev = "e3eccacf96bc6e041a7ec6623e2251dba1129f28" } | ||
| llm-tokenizer = { git = "https://github.com/lightseekorg/smg", rev = "e3eccacf96bc6e041a7ec6623e2251dba1129f28" } | ||
|
|
||
| # Backport ai-dynamo/modelexpress#467 to v0.3.0 until an upstream release includes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modelexpress-clientandmodelexpress-commonpins into the standalone frontend Python-binding Cargo workspacerushilbhat/modelexpressat46e4633a33a9a9183bda97ee5bb3411dd4992d7cWhy
lib/bindings/pythondeclares its own Cargo workspace, so it does not inherit[patch.crates-io]from the repository root. The frontend image build runsmaturin buildfrom that workspace and was therefore still compiling the crates.io ModelExpress 0.3.0 release. That left the Hugging Face missing-Content-Rangefailure in the new frontend image and prevented discovered models such as GLM 5.2 from being registered.This mirrors the root pins into the workspace that actually produces the frontend Rust extension. The fork is based on ModelExpress v0.3.0 and backports ai-dynamo/modelexpress#467.
Validation
cargo tree --manifest-path lib/bindings/python/Cargo.toml --locked -i modelexpress-commoncargo tree --manifest-path lib/bindings/python/Cargo.toml --locked -i modelexpress-clientcargo check --manifest-path lib/bindings/python/Cargo.toml --lockedBoth dependency-tree checks resolve to fork commit
46e4633a, and the frontend workspace check passes.