feat: expose scrollback buffer with scrollback_rows(), scrollback_row_count(), and clear_scrollback() methods#22
Closed
davidbeesley wants to merge 6 commits into
Closed
feat: expose scrollback buffer with scrollback_rows(), scrollback_row_count(), and clear_scrollback() methods#22davidbeesley wants to merge 6 commits into
davidbeesley wants to merge 6 commits into
Conversation
…_count(), and clear_scrollback() methods
Row was being exported via `pub use row::Row` which triggered 22 clippy errors for missing documentation, #[must_use] attributes, and panic docs. Since Row is returned via `impl Iterator<Item = &Row>`, users can still call its public methods without needing to name the type directly.
…ear_scrollback() Tests cover: - scrollback_row_count with various buffer states - scrollback_rows iterator and cell access - clear_scrollback resets count and offset
Changed scrollback_rows() to take (start, width) parameters and return impl Iterator<Item = String>, matching the existing rows() API pattern. This provides a consistent API and avoids exposing the internal Row type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollback_rows()method to retrieve rows from the scrollback bufferscrollback_row_count()method to get the number of rows in the scrollback bufferclear_scrollback()method to clear the scrollback bufferThese methods provide access to the scrollback buffer which was previously internal-only, enabling applications to read terminal history and manage scrollback programmatically.