[integration/peerlab] Bugfix/torch array overlow#45
Merged
Conversation
Collaborator
Author
|
Attached is the script used to test if the new chunking logic yields identical results to the previous implementatino. Outputs: @andrewmoorman FYI, will merge tomorrow if you see no issues. :) |
07baac1 to
a134e17
Compare
Collaborator
Author
|
Prediction graph now works. While performance for predicting is very slow now, this fix solved the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44 . Subsetting a graph with over 2.1B edges is not supported in torch
2.5.1(which is often the version it's resolved to). Instead, use indices instead of boolean arrays to subset the graph. These can be obtained using chunks.Also improve logging logic.