Remove some unused code #1925
Merged
Remove some unused code #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
remove-some-unused-code
branch
from
97b0e05 to
1e1b13d
Compare
dpkp
approved these changes
Dec 29, 2019
kafka/producer/buffer.py
Outdated
| with self._lock: | ||
| return len(self._waiters) | ||
|
|
||
| # TODO should this be removed or finished? |
Owner
There was a problem hiding this comment.
This is fine to remove. Memory allocation is not a bottleneck as far as I can tell.
kafka/protocol/struct.py
Outdated
| return False | ||
| return True | ||
|
|
||
| # TODO should this be removed or finished? |
kafka/util.py
Outdated
| pass | ||
|
|
||
|
|
||
| # TODO what is the purpose of this? It has been unused since it was originally added |
Owner
There was a problem hiding this comment.
I was thinking about using this to help prevent circular references when calling instance methods with atexit . Currently we only do that in the producer, and we use weakproxy directly. If we ever needed to do a similar cleanup for other classes then this method might be helpful. But I don't mind if you delete it.
Repository owner
deleted a comment from
dpkp
Feb 5, 2020
jeffwidman
force-pushed
the
remove-some-unused-code
branch
from
1e1b13d to
1dace1d
Compare
jeffwidman
force-pushed
the
remove-some-unused-code
branch
from
1dace1d to
ca2d763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these are
TODO's, but hopefully @dpkp can provide backstory on whether to remove these or leave them in...This change is