Skip to content

Initiate Coordinator Reconnect w/ Backoff from Heartbeat Thread #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

Initiate Coordinator Reconnect w/ Backoff from Heartbeat Thread #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5ed1d
Only use coordinator time_to_next_poll if group_id is set
dpkp Nov 20, 2025
061659b
Connect coordinator from heartbeat thread if needed
dpkp Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kafka/consumer/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,9 @@ def _poll_once(self, timer, max_records, update_offsets=True):

# We do not want to be stuck blocking in poll if we are missing some positions
# since the offset lookup may be backing off after a failure
poll_timeout_ms = min(timer.timeout_ms, self._coordinator.time_to_next_poll() * 1000)
poll_timeout_ms = timer.timeout_ms
if self.config['group_id'] is not None:
poll_timeout_ms = min(poll_timeout_ms, self._coordinator.time_to_next_poll() * 1000)
if not has_all_fetch_positions:
log.debug('poll: do not have all fetch positions...')
poll_timeout_ms = min(poll_timeout_ms, self.config['retry_backoff_ms'])
Expand Down
1 change: 1 addition & 0 deletions kafka/coordinator/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,7 @@ def _run_once(self):
self.coordinator._lock.wait(self.coordinator.config['retry_backoff_ms'] / 1000)

elif not self.coordinator.connected():
self.coordinator._client.maybe_connect(self.coordinator.coordinator_id)
self.coordinator._client._lock.release()
self.coordinator._lock.wait(self.coordinator.config['retry_backoff_ms'] / 1000)

Expand Down
Loading