Drop the mutable default in _estimate_size_in_bytes#2840
Closed
basheer-cloud wants to merge 2 commits intodpkp:masterfrom
Closed
Drop the mutable default in _estimate_size_in_bytes#2840basheer-cloud wants to merge 2 commits intodpkp:masterfrom
basheer-cloud wants to merge 2 commits intodpkp:masterfrom
Conversation
Owner
|
Thanks - it looks like your PR inadvertently includes another commit from a different PR that recently landed. Can you rebase -i so that this PR only includes your changes? |
Owner
|
Resolved conflicts w/ cherry-pick in #2865 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this while reading through the code path around kafka/producer/kafka.py. Drop the mutable default in _estimate_size_in_bytes. Mutable defaults are shared across calls and usually turn into state leaks. I kept the patch small and re-ran syntax checks after applying it.