Skip to content

Catch KafkaUnavailableError in _send_broker_aware_request #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 3 commits into from
Oct 7, 2015
Merged

Catch KafkaUnavailableError in _send_broker_aware_request #436

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
718e5fb
Treat KafkaUnavailableError like other errors.
mutability Jul 19, 2015
3376ed1
Errors -> Error typo
mutability Jul 20, 2015
77e5180
Init responses before we use it.
mutability Jul 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions kafka/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,16 +161,21 @@ def _send_broker_aware_request(self, payloads, encoder_fn, decoder_fn):
brokers_for_payloads = []
payloads_by_broker = collections.defaultdict(list)

responses = {}
for payload in payloads:
leader = self._get_leader_for_partition(payload.topic,
payload.partition)

payloads_by_broker[leader].append(payload)
brokers_for_payloads.append(leader)
try:
leader = self._get_leader_for_partition(payload.topic,
payload.partition)
payloads_by_broker[leader].append(payload)
brokers_for_payloads.append(leader)
except KafkaUnavailableError as e:
log.warning('KafkaUnavailableError attempting to send request '
'on topic %s partition %d', payload.topic, payload.partition)
topic_partition = (payload.topic, payload.partition)
responses[topic_partition] = FailedPayloadsError(payload)

# For each broker, send the list of request payloads
# and collect the responses and errors
responses = {}
broker_failures = []
for broker, payloads in payloads_by_broker.items():
requestId = self._next_id()
Expand Down