chore: add cuckoo to compact object by kostasrim · Pull Request #7645 · dragonflydb/dragonfly

kostasrim · 2026-06-18T15:09:58Z

integrate CuckooFilter to CompactObject

resolves #7579

qodo-free-for-open-source-projects · 2026-06-18T15:17:00Z

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📜 Skill insights (0)

1. RDB save crashes on cuckoo 🐞 Bug ≡ Correctness

Description

CompactObj::ObjType() can now return OBJ_CUCKOOFILTER, but RdbObjectType() in rdb_save.cc has no
case for it and falls through to LOG(FATAL), crashing during snapshot/backup when such a value is
saved.

Code

src/core/compact_object.cc[R946-947]
+    case CUCKOO_FILTER_TAG:
+      return OBJ_CUCKOOFILTER;

Evidence

The PR makes cuckoo filters a first-class CompactObj type (ObjType can return OBJ_CUCKOOFILTER). The
RDB save code enumerates supported types and then unconditionally LOG(FATAL)s for unknown ones;
since OBJ_CUCKOOFILTER is not handled, encountering it during snapshot/backup will crash.

src/core/compact_object.cc[911-952]
src/redis/redis_aux.h[9-20]
src/server/rdb_save.cc[165-212]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`CompactObj` can now represent `OBJ_CUCKOOFILTER` (via `CUCKOO_FILTER_TAG`), but the RDB serialization dispatch (`RdbObjectType`/`SaveObject` and the loader side) does not recognize this type. If a cuckoo-filter value is present during snapshot/backup, `RdbObjectType()` will hit its fallback `LOG(FATAL)` path and terminate the process.

## Issue Context
Dragonfly uses custom DF RDB types for module-like objects (JSON/SBF/CMS/TOPK). CuckooFilter needs the same end-to-end wiring: type id, save path, and load path.

## Fix Focus Areas
- src/server/rdb_extensions.h[11-25]
- src/server/rdb_save.cc[165-212]
- src/server/rdb_save.cc[334-376]
- src/server/rdb_load.cc[1261-1294]
- src/core/compact_object.cc[911-952]

## What to implement
1. Introduce a new DF RDB type constant (e.g. `RDB_TYPE_CUCKOOFILTER = 37`) and include it in `rdbIsObjectTypeDF`.
2. Update `RdbObjectType(const CompactObj&)` to map `OBJ_CUCKOOFILTER` to `RDB_TYPE_CUCKOOFILTER`.
3. Add `SaveCuckooFilterObject(const PrimeValue&)` and dispatch it from `SaveObject()` when `obj_type == OBJ_CUCKOOFILTER`.
4. Update `RdbLoaderBase` switch to recognize `RDB_TYPE_CUCKOOFILTER` and implement `ReadCuckooFilter()` that reconstructs `PrimeValue` via `SetCuckooFilter(...)` and restores the filter contents.
5. Add a save+load roundtrip test similar to SBF/CMS/TOPK to ensure snapshots work with cuckoo filters.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Cuckoo type label typo 🐞 Bug ◔ Observability

Description

ObjTypeToString maps OBJ_CUCKOOFILTER to "MCuckooFIlter-TYPE" (typo/casing), which will surface in
metrics labels and debug outputs that rely on ObjTypeToString().

Code

src/core/compact_object.cc[R2051-2052]

+    {OBJ_TOPK, "TopK-TYPE"sv},
+    {OBJ_CUCKOOFILTER, "MCuckooFIlter-TYPE"sv}};

Evidence
The PR adds the new ObjType->string mapping with a typo. The server’s metrics exporter uses
ObjTypeToString() to emit per-type memory usage labels, so the typo becomes externally visible.
src/core/compact_object.cc[2040-2053]
src/server/server_family.cc[1827-1838]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`ObjTypeToString()` exports a misspelled/inconsistently-cased string for `OBJ_CUCKOOFILTER` ("MCuckooFIlter-TYPE"). This string is used in user-visible/debug output and as a metrics label value, so the typo leaks externally and can create inconsistent labeling.

## Issue Context
Per-type memory metrics use `ObjTypeToString(type)` as the label value.

## Fix Focus Areas
- src/core/compact_object.cc[2040-2053]
- src/server/server_family.cc[1827-1838]

## What to change
- Replace "MCuckooFIlter-TYPE" with the intended canonical spelling (e.g. "MCuckooFilter-TYPE"), matching the style of existing module-like labels (SBF/CMS/TOPK).
- (Optional but recommended) Add/extend a small unit test that validates `ObjTypeFromString(ObjTypeToString(x)) == x` for `OBJ_CUCKOOFILTER` to prevent future label regressions.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

qodo-free-for-open-source-projects · 2026-06-18T15:17:01Z

+    case CUCKOO_FILTER_TAG:
+      return OBJ_CUCKOOFILTER;


1. Rdb save crashes on cuckoo 🐞 Bug ≡ Correctness

CompactObj::ObjType() can now return OBJ_CUCKOOFILTER, but RdbObjectType() in rdb_save.cc has no case for it and falls through to LOG(FATAL), crashing during snapshot/backup when such a value is saved.

Agent Prompt

## Issue description `CompactObj` can now represent `OBJ_CUCKOOFILTER` (via `CUCKOO_FILTER_TAG`), but the RDB serialization dispatch (`RdbObjectType`/`SaveObject` and the loader side) does not recognize this type. If a cuckoo-filter value is present during snapshot/backup, `RdbObjectType()` will hit its fallback `LOG(FATAL)` path and terminate the process. ## Issue Context Dragonfly uses custom DF RDB types for module-like objects (JSON/SBF/CMS/TOPK). CuckooFilter needs the same end-to-end wiring: type id, save path, and load path. ## Fix Focus Areas - src/server/rdb_extensions.h[11-25] - src/server/rdb_save.cc[165-212] - src/server/rdb_save.cc[334-376] - src/server/rdb_load.cc[1261-1294] - src/core/compact_object.cc[911-952] ## What to implement 1. Introduce a new DF RDB type constant (e.g. `RDB_TYPE_CUCKOOFILTER = 37`) and include it in `rdbIsObjectTypeDF`. 2. Update `RdbObjectType(const CompactObj&)` to map `OBJ_CUCKOOFILTER` to `RDB_TYPE_CUCKOOFILTER`. 3. Add `SaveCuckooFilterObject(const PrimeValue&)` and dispatch it from `SaveObject()` when `obj_type == OBJ_CUCKOOFILTER`. 4. Update `RdbLoaderBase` switch to recognize `RDB_TYPE_CUCKOOFILTER` and implement `ReadCuckooFilter()` that reconstructs `PrimeValue` via `SetCuckooFilter(...)` and restores the filter contents. 5. Add a save+load roundtrip test similar to SBF/CMS/TOPK to ensure snapshots work with cuckoo filters.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

augmentcode · 2026-06-18T15:21:40Z

🤖 Augment PR Summary

Summary: This PR adds Cuckoo Filter support to Dragonfly’s CompactObj value representation (resolving #7579).

Changes:

Introduced CUCKOO_FILTER_TAG/OBJ_CUCKOOFILTER and wired them into Size(), ObjType(), Free(), and MallocUsed()
Added SetCuckooFilter/GetCuckooFilter APIs and corresponding union storage
Implemented CuckooFilter::MallocUsed() (renaming the prior helper) and updated unit tests
Extended ObjTypeToString mapping and compact object tests to cover the new type

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>

kostasrim · 2026-06-18T15:45:53Z

-                               [](const SubFilter& sf) { return sf.size(); });
+size_t CuckooFilter::MallocUsed() const {
+  size_t res = sizeof(CuckooFilter) + filters_.capacity() * sizeof(SubFilter);
+  for (const SubFilter& sf : filters_) {


@dranikpg never again, I accept my defeat 😄

kostasrim · 2026-06-18T15:46:58Z

augment review

augmentcode

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-06-18T15:52:00Z

  void SetCMS(uint32_t width, uint32_t depth);
  CMS* GetCMS() const;

+  void SetCuckooFilter(CuckooFilter* cf) {


SetCuckooFilter(CuckooFilter* cf) stores a raw pointer, but CompactObj::Free() later calls DeleteMR<CuckooFilter>, which assumes cf was allocated via CompactObj::AllocateMR (same thread-local MR). Without an explicit ownership/allocator contract here, it’s easy for a future caller to pass a differently-allocated filter and trigger invalid deallocation.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

kostasrim self-assigned this Jun 18, 2026

qodo-free-for-open-source-projects Bot reviewed Jun 18, 2026

View reviewed changes

augmentcode Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread src/core/compact_object.cc Outdated

kostasrim force-pushed the kcuckoo2 branch 2 times, most recently from fe039aa to c13082f Compare June 18, 2026 15:41

chore: add cuckoo to compact object

cf8f9c4

Signed-off-by: Kostas Kyrimis <kostas@dragonflydb.io>

kostasrim force-pushed the kcuckoo2 branch from c13082f to cf8f9c4 Compare June 18, 2026 15:44

kostasrim commented Jun 18, 2026

View reviewed changes

augmentcode Bot reviewed Jun 18, 2026

View reviewed changes

kostasrim requested review from abhijat and dranikpg June 19, 2026 09:24

dranikpg approved these changes Jun 19, 2026

View reviewed changes

kostasrim merged commit 05060af into main Jun 22, 2026
17 of 23 checks passed

kostasrim deleted the kcuckoo2 branch June 22, 2026 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: add cuckoo to compact object - #7645

chore: add cuckoo to compact object#7645
kostasrim merged 1 commit into
mainfrom
kcuckoo2

kostasrim commented Jun 18, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 18, 2026

Uh oh!

qodo-free-for-open-source-projects Bot Jun 18, 2026

Uh oh!

augmentcode Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

augmentcode Bot left a comment

Uh oh!

Uh oh!

kostasrim Jun 18, 2026

Uh oh!

kostasrim commented Jun 18, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

augmentcode Bot Jun 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kostasrim commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 18, 2026

Code Review by Qodo

Uh oh!

qodo-free-for-open-source-projects Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kostasrim Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

kostasrim commented Jun 18, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kostasrim commented Jun 18, 2026 •

edited

Loading

augmentcode Bot commented Jun 18, 2026 •

edited

Loading

augmentcode Bot Jun 18, 2026 •

edited

Loading