Skip to content

facade: reduce pipeline preference log verbosity - #7900

Merged
romange merged 1 commit into
mainfrom
connection-vlog-level
Jul 21, 2026
Merged

facade: reduce pipeline preference log verbosity#7900
romange merged 1 commit into
mainfrom
connection-vlog-level

Conversation

@romange

@romange romange commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

We should avoid logging VERY frequent events (potentially per request) as VLOG(1) as then we can not
use this logging level in prod.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@romange
romange requested a review from glevkovich July 21, 2026 10:29
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Jul 21, 2026

Copy link
Copy Markdown

Code Review by Qodo


New Review Started

This review has been superseded by a new analysis

Powered by Qodo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary by Qodo

facade: reduce pipeline preference log verbosity

✨ Enhancement 🕐 Less than 10 minutes


AI Description

• Reduce log verbosity when pipeline execution is preferred over admin queue.
• Keep diagnostic details available at higher VLOG level.
High-Level Assessment

The change is appropriately minimal: lowering the VLOG level preserves useful diagnostics while reducing default verbosity. No alternative approach is warranted for a one-line logging tweak.

Files changed (1) +1 / -1

Enhancement (1) +1 / -1
dragonfly_connection.ccLower VLOG level for pipeline-preference message +1/-1

Lower VLOG level for pipeline-preference message

• Changes the pipeline-preference log statement from VLOG(1) to VLOG(2) so it appears only at higher verbosity while retaining the same message content.

src/facade/dragonfly_connection.cc

@augmentcode

augmentcode Bot commented Jul 21, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Reduces log noise for the pipeline-vs-admin-queue scheduling decision in Connection::AsyncFiber().

Changes: Raises the VLOG_IF level for the “Preferring pipeline execution…” message from 1 to 2 so it only appears with higher verbosity settings.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@romange
romange enabled auto-merge (squash) July 21, 2026 10:31
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

@romange
romange merged commit 60c4098 into main Jul 21, 2026
14 checks passed
@romange
romange deleted the connection-vlog-level branch July 21, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants