preparing v10.0.1 - #27
Merged
Merged
Conversation
…ws, and with nothing linking to it
A playground and a kitchen sink under React are unbundled ES modules: the page
names an entry, the entry imports the component, the component imports its class
table and the layer's `ArenaStyles`, `Tokens` and the rest. `build-site.ts`
copied the page and the entry beside it and stopped there, so
`ArenaSelect.demo.generated.html` answered 200, every `href` and `src` on it
answered 200, and `#root` stayed empty: the first import 404ed before a line of
the entry had run. Angular was never affected, arriving pre-bundled in
`frameworks/angular/build/demo`, which was already copied whole.
The set is walked from the pages now rather than named by a rule about file
names -- an import map target, a `<script type="module">`, and every specifier
reached from there to the leaves. It is 385 modules, and 8 of them are the
layer's own roots that no rule about a demo entry would ever have reached.
Nothing was holding that. `check:site` read `href`, `src` and markdown links,
and an `href` is not the whole of what a page loads: a module script resolving
says nothing about what that entry imports. It reads the graph now, and against
the output as it stood it reported 152 of them.
`module-graph.ts` is a util because it names nothing of Arena, and it asks an
HTML target and an import specifier two different questions, being two
notations: a `src` is a URL, so a bare name is a path, while a specifier is an ES
one, so a bare name is the import map's and following it as a path reports the
map's own key as a file nobody wrote. Both import patterns anchor at a statement
boundary and require the `from`, because `export function ArenaBreadcrumbs({
separator = "/" })` opens with `export` and quotes a default argument, and read
as a specifier that is an import of the root of the filesystem -- which it was,
on the first walk.
The other half is that the 146 pages this fixed were reachable only by knowing
their URL. The kitchen sink has an index and its own entry in the one list the
landing page and the dev server both read, and the playgrounds had neither, so
"See it" offered five links to a site publishing a hundred and seventy pages.
Each layer indexes `frameworks/<layer>/components/` now, the 73 grouped under
the 7 categories the tree already sorts them into, and `entryPoints()` carries
the two new stops, which is why `serve.ts` needed no edit. `indexPage` takes
sections rather than a list, and the indexes that had none return one section
without a heading: one shape, no exception. `linksFor`'s `directory === ''`
branch went with it, unreachable since `landingPage()` builds its own cards.
One route budget is raised. `contributor-gate` broke on the 281 characters
`check:site` added to its row, with 7 characters of headroom left of the last
raise, so what the break reported was that raise having been spent to the
character rather than this row.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.