1.14.2-drbergman-2.3.1#41
Merged
Merged
Conversation
- division vector was not normalized after orthogonal projection onto orientation-defined plane
- this would lead to inconsistent displacements
- e.g. in 2D, a rand_vec of (0,0,1) would lead to 0 displacement
- the daughter cell was displaced by the full radius and the parent cell by half the radius in the opposite direction
- this led to a center of mass shift (in the rand_vec direction) of radius/4
- now, both are displaced by half the radius in opposite directions, preserving center of mass
- by using 1/2 the radius, the cells will remain overlapping, which the mechanics module will resolve over time
Fix division displacement my pc
- bottom line: at each mechanics time step, it will suffice to push the cell in a cardinal direction to increase the shortest distance to the boundary - this is precisely what the current code currently does the vast majority of the time. - now, it will do so for the previously defined edge cases - in 2D sims, they looked for cells on line y=x - then used signs of x and y positions to determine which direction to push - no check for cells in upper left or lower right corners - the sign of the positions does not accurately convey which way to push (if all corners are negative, they would all push the same way) - in 3D sims, they looked for cells on line x=y=z - similar issues but missing more cases (x=\pm y = \pm z)
Fix dist to edge edge cases my pc
always check sbml_filename exists and set properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.