fix(ssms): improve SSMS installation check and command parameters - #343
Merged
Conversation
ansible-lint's schema[tasks] rule requires the fully-qualified name `ansible.builtin.runas` rather than the short `runas` form. The rule is not skippable, so the bare form fails the Pre-Commit workflow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Improves the mssql_ssms Ansible role to more reliably detect existing SSMS installations on newer Windows hosts and to invoke the modern SSMS bootstrapper with appropriate command-line flags and elevation.
Changes:
- Updated SSMS install detection to search both
Program Filesroots and locateSsms.exerather than relying on version-pinned x86 paths. - Updated installer invocation to use
--quiet --norestart --wait, run asSYSTEM, and treat exit code3010(reboot required) as success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SQL Server Management Studio (SSMS) installation on newer Windows hosts by improving installation detection and updating the installer invocation to match the behavior of current SSMS releases.
These changes make the installation process more reliable across fresh GOAD deployments while remaining backwards compatible with existing lab provisioning.
Type of change
Area
cli/)ansible/)infra/,modules/)packer/,warpgate-templates/)ad/)extensions/)tools/)docs/,README.md, etc.).github/)Related issues
Related to the SQL Server Management Studio installation issues discussed in Orange-Cyberdefense/GOAD#480.
How was this tested?
Verified provisioning successfully installs SSMS when it is not already present.
Verified existing SSMS installations are detected correctly and skipped.
Confirmed the updated installer command executes successfully with the current Microsoft SSMS bootstrapper.
Provider(s) tested: Hyper-V
Lab(s) tested: GOAD
Operator OS: Linux (Ansible control host)
Screenshots / logs (optional)
N/A
Checklist
docs/, role README, command help text) where relevant.ad/,ansible/, andextensions/are expected and fine.)--helptext and any docs that reference it.