Skip to content

fix(datasets): removed is_public - #258

Merged
briangreunke merged 1 commit into
feat/datasetsfrom
fix/remove-is-public
Dec 10, 2025
Merged

fix(datasets): removed is_public#258
briangreunke merged 1 commit into
feat/datasetsfrom
fix/remove-is-public

Conversation

@briangreunke

@briangreunke briangreunke commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR addresses the removal of the is_public field from the DatasetMetadata model.

Changes

API Models

  • Removed is_public field: The is_public: bool field has been removed from the DatasetMetadata Pydantic model in dreadnode/api/models.py. This impacts how dataset visibility is represented and handled within the API.

Generated Summary:

  • Simplified error message in the _validate_key function for clarity by removing unnecessary line breaks.
  • Removed the is_public field from DatasetMetadata, which may affect how dataset visibility is handled in the application.
  • These changes improve code readability and may require updates in related components that depend on the is_public attribute.

This summary was generated with ❤️ by rigging

@briangreunke
briangreunke merged commit f9a4cfa into feat/datasets Dec 10, 2025
1 check passed
@briangreunke
briangreunke deleted the fix/remove-is-public branch December 10, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant