Skip to content

Add user override for default stage direction background and text colour#1287

Merged
Tim020 merged 4 commits into
devfrom
feature/default-stage-direction-style
Jul 9, 2026
Merged

Add user override for default stage direction background and text colour#1287
Tim020 merged 4 commits into
devfrom
feature/default-stage-direction-style

Conversation

@Tim020

@Tim020 Tim020 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds default_sd_background_colour and default_sd_text_colour columns to UserSettings so users can personalise the fallback appearance of unstyled stage direction lines
  • Existing hardcoded darkslateblue fallback is preserved when no override is set
  • UI added to the Stage Direction Styles tab in user settings (both Vue 3 and Vue 2 clients), with a live-preview modal and a Reset to Default button
  • Alembic migration included; alembic check confirms model and DB are in sync
  • E2E coverage added for the new Customise/Reset flow in 14-user-settings.spec.ts
  • User documentation updated in docs/pages/user_settings.md

Test plan

  • Backend: pytest — 704 tests pass
  • Vue 3: npm run typecheck + npm run ci-lint — clean
  • Vue 2: npm run typecheck + npm run ci-lint — clean
  • alembic check — no new upgrade operations detected
  • Open User Settings → Stage Direction Styles tab; confirm "Default Stage Direction Style" card is present
  • Click Customise, pick a colour, click OK — confirm preview updates and Reset button appears
  • Click Reset to Default — confirm Reset button disappears and preview reverts to dark blue
  • Navigate to a script with unstyled stage directions — confirm colour change is reflected in both config and live views
  • Full Playwright E2E suite passes

🤖 Generated with Claude Code

@Tim020 @claude
Add user override for default stage direction background and text colour
8a644a2 
Adds two new nullable columns to UserSettings (default_sd_background_colour,
default_sd_text_colour) so users can personalise the fallback appearance applied
to unstyled stage direction lines. Includes UI in both Vue 3 and Vue 2 clients,
an Alembic migration, E2E coverage, and updated user documentation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Tim020 Tim020 added the claude Issues created by Claude label Jul 7, 2026
@github-actions github-actions Bot added documentation Improvements or additions to documentation client Pull requests changing front end code large-diff server Pull requests changing back end code client-v3 labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Client V3 Test Results

23 tests   23 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit f9ba89d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Client Test Results

128 tests   128 ✅  0s ⏱️
  6 suites    0 💤
  1 files      0 ❌

Results for commit f9ba89d.

♻️ This comment has been updated with latest results.

Tim020 and others added 2 commits July 7, 2026 11:30
@Tim020 @claude
Fix ruff import ordering in migration file
8309bc2 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Tim020 @claude
Expand E2E coverage for default stage direction style feature
c77bc2e 
Adds full end-to-end coverage: default preview colour assertion (verifies
darkslateblue fallback), WS sync round-trip (preview updates after PATCH),
persistence across page reload (GET /api/v1/user/settings), text colour
override path, and Reset to Default restoring the fallback.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Python Test Results

  1 files    1 suites   2m 17s ⏱️
704 tests 704 ✅ 0 💤 0 ❌
709 runs  709 ✅ 0 💤 0 ❌

Results for commit f9ba89d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Playwright E2E Results (firefox)

217 tests   217 ✅  2m 12s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit f9ba89d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Playwright E2E Results (chromium)

217 tests   217 ✅  2m 15s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit f9ba89d.

♻️ This comment has been updated with latest results.

@Tim020 @claude
Fix default stage direction modal colours and always-show Reset button
f9ba89d 
- Fix background colour picker initialising to #2f4f4f (darkslategray)
  instead of #483d8b (darkslateblue) when no override is set
- Reset to Default button is now always visible; disabled when there is
  no override to clear rather than hidden with v-if
- Update E2E assertions from toBeVisible/not.toBeVisible to
  toBeEnabled/toBeDisabled to match the new always-visible button

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

@Tim020 Tim020 enabled auto-merge (squash) July 9, 2026 09:44
@Tim020 Tim020 merged commit e3393e3 into dev Jul 9, 2026
35 checks passed
@Tim020 Tim020 deleted the feature/default-stage-direction-style branch July 9, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

claude Issues created by Claude client Pull requests changing front end code client-v3 documentation Improvements or additions to documentation server Pull requests changing back end code xlarge-diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Tim020