-
-
Notifications
You must be signed in to change notification settings - Fork 28
Updated versions in configs. #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update documentation to include an additional cache version increment location, and synchronize the PHP version in both the Composer and PHPStan configuration files from 8.3.12 to 8.3.23. No changes to code, dependencies, or public interfaces are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (4)
.vortex/installer/tests/Fixtures/install/_baseline/phpstan.neonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/install/hosting_acquia/phpstan.neonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/version_replacement/baseline/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**web/themes/custom/your_site_theme/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.vortex/docs/content/contributing/maintenance/release.mdx(1 hunks)composer.json(1 hunks)phpstan.neon(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Composer dependencies are updated automatically with compatibility checks via RenovateBot
composer.json (1)
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Composer dependencies are updated automatically with compatibility checks via RenovateBot
.vortex/docs/content/contributing/maintenance/release.mdx (3)
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Composer dependencies are updated automatically with compatibility checks via RenovateBot
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Node.js dependencies are updated in theme directories via RenovateBot
Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T15:00:28.327Z
Learning: Docker images are updated for containers via RenovateBot
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: build (1)
- GitHub Check: build (0)
- GitHub Check: vortex-test-deployment (0)
- GitHub Check: vortex-test-deployment (1)
- GitHub Check: vortex-test-workflow (3)
- GitHub Check: vortex-test-workflow (0)
- GitHub Check: vortex-test-installer (8.4)
- GitHub Check: vortex-test-workflow (2)
- GitHub Check: vortex-test-workflow (1)
- GitHub Check: vortex-test-common
- GitHub Check: vortex-test-installer (8.3)
- GitHub Check: vortex-test-installer (8.2)
- GitHub Check: vortex-test-docs
🔇 Additional comments (2)
composer.json (1)
94-98: Verify lock-file & CI images after bumpingplatform.phpThe version bump to 8.3.23 looks good and keeps Composer in sync with PHPStan.
Double-check that:
composer.lockhas been regenerated; otherwise CI may still resolve against the old PHP platform.- All CI/build images (Dockerfile, GitHub Actions, CircleCI) are explicitly using
8.3.23to avoid drift.If everything is already covered, feel free to ignore.
phpstan.neon (1)
12-15:phpVersionaligned — 👍
80323correctly mirrors the Composer platform bump. No further action required.
| 6. Increment minor version of all packages in `composer.json`. Run `composer update -W && composer bump`. | ||
| 7. Update minor version of dependencies in theme's `package.json`. | ||
| 8. Increment the cache version in `.circleci/config.yml`. | ||
| 8. Increment the cache version in `.circleci/config.yml` and `.github/workflows/build-test-deploy.yml`. | ||
| 9. Updated documentation with `cd .vortex && ahoy update-docs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcs.xml still references the old PHP ID
Release step 4 instructs updating phpcs.xml, but that file wasn’t changed in this PR.
Unless it’s already on 8.3.23, static-analysis in CI will now run with inconsistent version targets.
Either update phpcs.xml ( testVersion="8.3-8.3.23" ) or confirm it’s already correct.
🧰 Tools
🪛 LanguageTool
[grammar] ~13-~13: Use articles correctly
Context: ...t the current PHP version. 6. Increment minor version of all packages in `composer.js...
(QB_NEW_EN_OTHER_ERROR_IDS_11)
🤖 Prompt for AI Agents
In .vortex/docs/content/contributing/maintenance/release.mdx around lines 13 to
16, the release instructions mention updating phpcs.xml but the file was not
changed in this PR. Verify the current phpcs.xml file's testVersion attribute
and if it is not set to "8.3-8.3.23", update it accordingly to ensure the static
analysis in CI uses consistent PHP version targets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1833 +/- ##
========================================
Coverage 74.02% 74.02%
========================================
Files 84 84
Lines 4813 4813
Branches 35 35
========================================
Hits 3563 3563
Misses 1250 1250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Documentation
Chores