[#1664] Updated PHPStan config to prefer type checking over docblocks.

[AlexSkrypnyk]

Closes #1664

Summary by CodeRabbit

• Chores
  • Updated internal configuration to improve accuracy of type checking. No impact on user-facing features.

[coderabbitai]

Walkthrough

The PHPStan configuration file was updated to include the parameter treatPhpDocTypesAsCertain set to false. Additionally, ignoreErrors entries were enhanced by adding reportUnmatched: false. No other configuration changes or code modifications were made.

Changes

Cohort / File(s)	Change Summary
PHPStan Configuration phpstan.neon	Added treatPhpDocTypesAsCertain: false and reportUnmatched: false to specific ignoreErrors entries in the PHPStan configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Add Environments section to the README.dist.md (#1664)	❌	No changes to README.dist.md or documentation were made.

Possibly related PRs

• Updated versions in configs. #1833: Related update to PHPStan configuration focusing on PHP version parameter, complementary but non-overlapping changes.

Poem

A tweak in a config, so subtle, so neat,
PHPStan now checks with code, not just what docs repeat.
Ignore rules refined, no warnings to fight—
This rabbit hops happy, with everything right!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbaa8be and a7a786f.

⛔ Files ignored due to path filters (5)

• .vortex/installer/tests/Fixtures/install/_baseline/phpstan.neon is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/docroot/themes/custom/star_wars/yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/phpstan.neon is excluded by !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/hosting_acquia/web/themes/custom/star_wars/-yarn.lock is excluded by !**/*.lock, !.vortex/installer/tests/Fixtures/**
• .vortex/installer/tests/Fixtures/install/theme_absent/phpstan.neon is excluded by !.vortex/installer/tests/Fixtures/**

📒 Files selected for processing (1)

• phpstan.neon (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

phpstan.neon (5)

Learnt from: AlexSkrypnyk
PR: #1693
File: .vortex/installer/tests/Fixtures/install/hosting_acquia/docs/deployment.md:6-8
Timestamp: 2025-06-01T08:09:18.993Z
Learning: Do not review files in test fixture directories (e.g., files under paths containing /tests/Fixtures/ or similar test fixture patterns). These files are used for testing purposes and should remain as-is.

Learnt from: CR
PR: drevops/vortex#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-28T03:30:12.271Z
Learning: Applies to {composer.json,composer.lock} : Composer dependencies should be updated automatically with compatibility checks

Learnt from: AlexSkrypnyk
PR: #1693
File: .vortex/installer/tests/Fixtures/install/deploy_type_none_gha/.github/workflows/build-test-deploy.yml:1-4
Timestamp: 2025-06-01T08:08:59.071Z
Learning: Test fixture files (typically located in directories containing "fixture" or "test") should not be reviewed for code quality issues as they may intentionally contain incomplete, invalid, or malformed data for testing purposes.

Learnt from: AlexSkrypnyk
PR: drevops/vortex#0
File: :0-0
Timestamp: 2025-05-29T12:15:32.188Z
Learning: Do not review files in .vortex/installer/tests/Fixtures/install directory as they are test fixtures.

Learnt from: AlexSkrypnyk
PR: #1697
File: .vortex/installer/tests/Fixtures/install/provision_database_lagoon/docs/onboarding.md:16-17
Timestamp: 2025-06-02T00:41:36.321Z
Learning: DO NOT EVER REVIEW FILES IN .vortex/installer/tests/Fixtures/ directory - these are test fixtures and should not be reviewed under any circumstances.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

• GitHub Check: build (0)
• GitHub Check: build (1)
• GitHub Check: vortex-test-workflow (3)
• GitHub Check: vortex-test-workflow (1)
• GitHub Check: vortex-test-workflow (0)
• GitHub Check: vortex-test-workflow (2)
• GitHub Check: vortex-test-common
• GitHub Check: vortex-test-deployment (0)
• GitHub Check: vortex-test-deployment (1)
• GitHub Check: vortex-test-installer (8.3)
• GitHub Check: vortex-test-installer (8.4)
• GitHub Check: vortex-test-installer (8.2)
• GitHub Check: vortex-test-docs

🔇 Additional comments (3)

phpstan.neon (3)

29-30: LGTM! Good practice to prefer code analysis over docblocks.

This configuration change aligns perfectly with the PR objective and follows PHPStan best practices by making type analysis more strict and reliable through actual code inspection rather than potentially outdated docblock annotations.

---

42-42: LGTM! Good addition for configuration robustness.

Adding reportUnmatched: false prevents unnecessary warnings when this ignore rule doesn't match any current errors, making the PHPStan configuration more maintainable.

---

50-50: LGTM! Consistent with the previous addition.

This reportUnmatched: false addition maintains consistency with the test-related ignore rule and ensures the PHPStan configuration doesn't generate unnecessary warnings for hook implementation scenarios.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/1664-update-phpstan-config

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.21%. Comparing base (9398e0b) to head (a7a786f).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1866   +/-   ##
========================================
  Coverage    75.21%   75.21%           
========================================
  Files           84       84           
  Lines         4862     4862           
  Branches        35       35           
========================================
  Hits          3657     3657           
  Misses        1205     1205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.