You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a tag deployment is triggered from CI, the Lagoon deploy script (deploy-lagoon.sh) fails because neither VORTEX_DEPLOY_BRANCH nor VORTEX_DEPLOY_PR is set (or set to a tag name that Lagoon doesn't recognize as a branch)
Lagoon does not support tag-based deployments — it deploys based on branches and PRs
Added an early exit with success when VORTEX_DEPLOY_MODE=tag, printing an informational skip message
Added VORTEX_DEPLOY_MODE variable declaration to the Lagoon deploy script (consistent with how deploy.sh and deploy-artifact.sh handle it)
No actionable comments were generated in the recent review. 🎉
Walkthrough
Added a VORTEX_DEPLOY_MODE check to deploy-lagoon.sh that returns early and succeeds when set to "tag"; added a Bats unit test verifying tag-mode skips the Lagoon deployment; updated docs to list deploy-lagoon.sh as a deployment script option.
Changes
Cohort / File(s)
Summary
Deploy script scripts/vortex/deploy-lagoon.sh
Introduce VORTEX_DEPLOY_MODE (default: "branch") and an early-success exit path when VORTEX_DEPLOY_MODE="tag", logging skip messages and avoiding the Lagoon deployment flow.
Unit test .vortex/tests/bats/unit/deploy-lagoon.bats
Add Bats test "Tag deployment mode skips Lagoon deployment" that sets VORTEX_DEPLOY_MODE="tag" and asserts the script emits start/skip/finish messages.
Update documentation to include scripts/vortex/deploy-lagoon.sh alongside scripts/vortex/deploy.sh for the VORTEX_DEPLOY_MODE/deployment script examples.
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The PR title accurately describes the main change: adding logic to skip Lagoon deployment when VORTEX_DEPLOY_MODE is set to 'tag', which directly addresses issue #1219.
Linked Issues check
✅ Passed
The PR implements option 1 from issue #1219 by skipping Lagoon deployment for tag mode with a success exit and informational message, fully addressing the core requirement to prevent CI job failures.
Out of Scope Changes check
✅ Passed
All changes are directly in scope: deployment logic for tag mode in deploy-lagoon.sh, corresponding BATS unit test, and documentation updates to reflect the new VORTEX_DEPLOY_MODE variable.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/1219-lagoon-tag-deploy
Comment @coderabbitai help to get the list of available commands and usage tips.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.14%. Comparing base (9af076d) to head (be10c30). ⚠️ Report is 1 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-lagoon.sh) fails because neitherVORTEX_DEPLOY_BRANCHnorVORTEX_DEPLOY_PRis set (or set to a tag name that Lagoon doesn't recognize as a branch)VORTEX_DEPLOY_MODE=tag, printing an informational skip messageVORTEX_DEPLOY_MODEvariable declaration to the Lagoon deploy script (consistent with howdeploy.shanddeploy-artifact.shhandle it)Closes #1219
Test plan
deploy-lagoon.batstests passdeploy.batstests passSummary by CodeRabbit
New Features
Tests
Documentation