Skip to content

[#2794] Added 'pull-requests: read' permission to CI deploy job for 'gh pr view'. #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 5 commits into from
Jul 16, 2026
Merged

[#2794] Added 'pull-requests: read' permission to CI deploy job for 'gh pr view'. #2797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f057fdb
[#2794] Added 'pull-requests: read' permission to deploy job for 'gh …
AlexSkrypnyk Jul 16, 2026
4b9eb0c
Updated snapshots.
AlexSkrypnyk Jul 16, 2026
7297642
[#2794] Removed inline comments from 'permissions' entries in 'build-…
AlexSkrypnyk Jul 16, 2026
6efb4cc
Updated snapshots.
AlexSkrypnyk Jul 16, 2026
f7dff23
Re-triggered CI to clear a flaky check.
AlexSkrypnyk Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ env:
DOCKER_CONFIG: /tmp/.docker

permissions:
contents: read # Minimal default for all jobs; jobs that need more override below.
contents: read

jobs:

Expand Down Expand Up @@ -334,9 +334,9 @@ jobs:
#;> !PROVISION_TYPE_PROFILE

permissions:
contents: read # Check out the repository.
checks: write # Publish test results to the Checks tab.
pull-requests: write # Comment on the pull request.
contents: read
checks: write
pull-requests: write

strategy:
# A matrix to run multiple jobs in parallel.
Expand Down Expand Up @@ -624,6 +624,10 @@ jobs:
if: ${{ !cancelled() && (inputs.deploy_target || (success() && github.event_name != 'schedule' && !startsWith(github.head_ref || github.ref_name, 'deps/') && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')))) }}
#;> !PROVISION_TYPE_PROFILE

permissions:
contents: read
pull-requests: read

container:
# https://hub.docker.com/r/drevops/ci-runner
image: drevops/ci-runner:26.6.0@sha256:190027056cac7b7ce28c29a1e5494779ebadc4ee8e95d468b75bc56e7be5aabd
Expand Down
12 changes: 8 additions & 4 deletions ...nstaller/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ env:
DOCKER_CONFIG: /tmp/.docker

permissions:
contents: read # Minimal default for all jobs; jobs that need more override below.
contents: read

jobs:

Expand Down Expand Up @@ -289,9 +289,9 @@ jobs:
if: ${{ !inputs.deploy_target && github.event_name != 'schedule' && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')) }}

permissions:
contents: read # Check out the repository.
checks: write # Publish test results to the Checks tab.
pull-requests: write # Comment on the pull request.
contents: read
checks: write
pull-requests: write

strategy:
# A matrix to run multiple jobs in parallel.
Expand Down Expand Up @@ -539,6 +539,10 @@ jobs:
needs: [build, lint]
if: ${{ !cancelled() && (inputs.deploy_target || (success() && github.event_name != 'schedule' && !startsWith(github.head_ref || github.ref_name, 'deps/') && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')))) }}

permissions:
contents: read
pull-requests: read

container:
# https://hub.docker.com/r/drevops/ci-runner
image: drevops/ci-runner:__VERSION__
Expand Down
6 changes: 5 additions & 1 deletion ...ts/Fixtures/handler_process/deploy_types_none_gha/.github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -533,100 +533,3 @@
@@ -533,104 +533,3 @@
timeout-minutes: 120 # Cancel the action after 120 minutes, regardless of whether a connection has been established.
with:
detached: true
Expand All @@ -8,6 +8,10 @@
- needs: [build, lint]
- if: ${{ !cancelled() && (inputs.deploy_target || (success() && github.event_name != 'schedule' && !startsWith(github.head_ref || github.ref_name, 'deps/') && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')))) }}
-
- permissions:
- contents: read
- pull-requests: read
-
- container:
- # https://hub.docker.com/r/drevops/ci-runner
- image: drevops/ci-runner:__VERSION__
Expand Down
6 changes: 3 additions & 3 deletions .../tests/Fixtures/handler_process/provision_profile/.github/workflows/build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
- if: ${{ !inputs.deploy_target && github.event_name != 'schedule' && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')) }}

permissions:
contents: read # Check out the repository.
contents: read
@@ -312,14 +199,6 @@
VORTEX_SSH_DISABLE_STRICT_HOST_KEY_CHECKING: "1"
VORTEX_SSH_REMOVE_ALL_KEYS: "1"
Expand Down Expand Up @@ -185,5 +185,5 @@
needs: [build, lint]
- if: ${{ !cancelled() && (inputs.deploy_target || (success() && github.event_name != 'schedule' && !startsWith(github.head_ref || github.ref_name, 'deps/') && (github.event_name == 'push' || !startsWith(github.head_ref, 'project/')))) }}

container:
# https://hub.docker.com/r/drevops/ci-runner
permissions:
contents: read