[#2848] Split provision example into demo, development module and example scripts. - #2859
Merged
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (67)
📒 Files selected for processing (14)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 86.84% 86.49% -0.36%
==========================================
Files 98 93 -5
Lines 4806 4671 -135
Branches 47 3 -44
==========================================
- Hits 4174 4040 -134
+ Misses 632 631 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a69763c345dd451d7e52fe2--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
AlexSkrypnyk
enabled auto-merge (squash)
July 29, 2026 04:08
AlexSkrypnyk
disabled auto-merge
July 29, 2026 04:08
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2848
Summary
scripts/provision-10-example.shwas documented as a disposable example ("Clone this file and modify it to your needs or simply remove it"), but it actually carried the entire non-production setup for the shipped site: the content model, the site name and admin navigation swap, the contrib and service modules, theys_base/ys_search/ys_democustom modules,drush deploy:hook, and thedevel/sdc_develdevelopment modules. A project that followed the header instruction and deleted the file lost all of it, including the development modules that have nothing to do with the demo content. This PR splits that single script into four scripts, each with a distinct two-digit prefix that now actually orders execution:provision-00-enable-demo-modules.sh(the renamed demo-site setup),provision-10-enable-dev-modules.sh(new, installsdevel/sdc_develbehind their own installer fences),provision-20-migration.shandprovision-30-search-index.sh(unchanged), andprovision-40-example.sh(new, a genuine no-op example). The installer, its tests, BATS coverage, and documentation are updated to match, and the installer now deletes the dev-modules script outright when neither module is selected, rather than shipping an empty shell.Changes
Scripts
scripts/provision-10-example.shtoscripts/provision-00-enable-demo-modules.sh, keeping therecipes/pagecontent model, site name, admin navigation swap (installsnavigation, uninstallstoolbar), contrib module list, Redis/ClamAV/Solr service modules,ys_base/ys_search/ys_democustom modules, anddrush deploy:hook. It runs first (prefix00) because the content model must exist before the modules that attach behaviour to it are installed.scripts/provision-10-enable-dev-modules.sh, installingsdc_develanddevel, each still behind its ownMODULE_SDC_DEVEL/MODULE_DEVELinstaller fence.scripts/provision-40-example.shas a genuine example: it demonstrates the environment guard and theVORTEX_PROVISION_OVERRIDE_DBfresh-database branch, and installs nothing.scripts/provision-20-migration.shandscripts/provision-30-search-index.share unchanged. Every shipped script now has a distinct two-digit prefix, which is what actually orders execution.Installer
Modules.phpgained aDEV_MODULESconstant and now removesscripts/provision-10-enable-dev-modules.shentirely when neitherdevelnorsdc_develis selected, because at that point the script has no operations left.scripts/provision-00-enable-demo-modules.sh. The demo script itself is only pruned by its existing token fences, never deleted, becauseconfig/default/ships empty and this script is the only thing that enables modules on a first provision.ModulesHandlerProcessTestgained amodules_no_devel_sdc_develdataset covering the whole-file removal.Tests
provision-enable-dev-modules.bats.provision-example.batsrenamed toprovision-enable-demo-modules.bats.provision-example.batscovers the new example script.provision.batsscenarios rewritten to expect three subscripts instead of one.SutTrait::assertVortexFilesPresent()now asserts all four shipped script names.Documentation
.vortex/tooling/README.mdlayout and prose updated to list every shipped script and distinguish the example from the scripts that do real work.provision.mdxgained a table of shipped scripts, plus Demo modules / Development modules sections..vortex/docs/content/drupal/provision-example.shaligned with the new minimal example.Before / After