[#2851] Removed the 'page' content model when the demo and search modules are deselected. - #2862
Merged
Merged
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (35)
📒 Files selected for processing (5)
WalkthroughThe installer now treats ChangesShared content model handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
==========================================
- Coverage 86.91% 86.48% -0.44%
==========================================
Files 100 93 -7
Lines 4830 4675 -155
Branches 47 3 -44
==========================================
- Hits 4198 4043 -155
Misses 632 632 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a6991033f8ba903bef1ea04--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
AlexSkrypnyk
added
the
Needs review
AlexSkrypnyk
force-pushed
the
feature/2851-demo-recipe-fence
branch
from
July 29, 2026 05:21
20237da to
a27f766
Compare
AlexSkrypnyk
added
AUTOMERGE
AlexSkrypnyk
enabled auto-merge (squash)
July 29, 2026 05:22
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
10 tasks
github-project-automation
Bot
moved this from In progress
to Release queue
in Vortex 1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2851
Summary
The
recipes/pagerecipe (the Basic page content type, its body field, and its form and view displays) previously survived every install unconditionally. It now carries aCONTENT_MODELfence token and is removed by the installer when neither thedemonor thesearchcustom module is selected.searchparticipates becausetests/behat/features/search.feature(tagged@search @p1) creates and indexespagecontent and is only removed when Solr is deselected, so removing the recipe purely on demo-deselect would leave a base+search project with a Behat feature referencing a content type that no longer exists.scripts/provision-00-enable-demo-modules.shfences the recipe-apply step with the same token and now reports a skip vianoteinstead of claiming success when the Drupal CLI is unavailable.Changes
recipes/page/behind a newCONTENT_MODELfence token, and wrapped the!recipes/pageallow-list entry in.gitignorein the same fence; the unfencedrecipes/*deny rule above it is untouched, since Composer still installs contrib recipes there and they must stay ignored regardless of this selection..vortex/installer/src/Prompts/Handlers/CustomModules.php::process()that runsFile::removeTokenAsync('CONTENT_MODEL')andFile::remove($t . '/recipes/page')only when neitherDEMOnorSEARCHremains in the final$selectedset. It runs after the per-module removal blocks so it reads$selectedpost safety-net (the existing safety net force-removesSEARCHwhen Solr is deselected)../vendor/bin/dr recipecall inscripts/provision-00-enable-demo-modules.shin#;< CONTENT_MODEL/#;> CONTENT_MODEL, and changed it to reportSkipped creating the content model: Drupal CLI is not available.vianoterather than unconditionally printingCreated the content model.when./vendor/bin/dris absent..vortex/docs/content/architecture.mdxto describe the.gitignoreallow-list pattern generically instead of citing!recipes/pageas a concrete example, since that entry is now conditional.assertDirectoryExists/assertDirectoryDoesNotExistassertions onrecipes/pageto thecustom_modules_no_demo,custom_modules_no_search,custom_modules_none, andcustom_modules_search_without_solrscenarios inCustomModulesHandlerProcessTest, and regenerated the installer fixture snapshots.Scope
The issue's acceptance criterion of "an install with the demo module deselected contains no
recipes/page" holds for the demo-off and search-off combination, not for demo-off alone - this is deliberate, since the recipe survives while either consumer still needs it. Each row below is covered by an existing fixture scenario:recipes/page_baselinecustom_modules_no_searchcustom_modules_no_democustom_modules_noneThe issue also named
web/modules/custom/ys_base/src/Plugin/DeployStep/CreateContentModelDeployStep.php; that file no longer exists, since commit e94fde1 replaced the DeployStep plugins with provision subscripts, and the recipe is now applied fromscripts/provision-00-enable-demo-modules.sh. The issue's requirement to checkys_basefor other demo-only code is satisfied by that same commit -ys_baseretains onlyhook_mail_alter, a theme-install deploy hook, and test scaffolding.Before / After
Summary by CodeRabbit
Bug Fixes
Documentation
User Experience