Scoped the paragraph create-access opinion to non-HTML requests. - #294
Conversation
The 'use content authoring api' gate also matched every role with 'is_admin', so administrators were treated as API clients and denied create access to 19 of 35 paragraph bundles in the node forms.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
|
Code coverage (threshold: 80%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
+ Coverage 81.49% 81.62% +0.13%
===========================================
Files 23 23
Lines 416 419 +3
===========================================
+ Hits 339 342 +3
Misses 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Checklist before requesting a review
[#123] Verb in past tense.#123added to descriptionChangedsectionChanged
RequestStackintoEntityCreateAccessHookand returnedAccessResult::neutral()whenever the current request format ishtml, before the API allow-list is evaluated - so the hook only opines on non-HTML (API) requests, which is the gap it was written to close.request_formatcache context to every return path in the hook, since the outcome now depends on it.EntityCreateAccessHookindo_content_api.services.ymlwith the@request_stackargument, following the existingModerationPolicyHookservice pattern.EntityCreateAccessHookTest's data provider with a$request_formatdimension and three new cases: HTML request with a disallowed bundle (neutral), HTML request with an allowed bundle (neutral), and no current request at all (still forbidden).Screenshots
Before / After