feat(item): two-way sliding of items

[manucorporat]

Short description of what this resolves:

Implements: feature(ion-item-sliding): Allow item also to swipe from left to right #5073

it should be 100% back compatible.

Changes proposed in this pull request:

• adds an optional side attribute to ion-item-options
• I aggressively refactored the sliding code to try to make it more readable and simple.
• moved logic to external functions so they can be unit tested easily

This may cause new issues. I haven't tested the code for side effects, so please don't merge just yet.
Feel free to pull it locally and try it.

Example code:

    <ion-item-sliding #item>
      <ion-item>Two-way sliding</ion-item>

      <!-- Same: <ion-item-options> -->
      <ion-item-options side="right">
        <button primary (click)="archive(item)">Archive</button>
        <button danger (click)="del(item)">Delete</button>
      </ion-item-options>

      <ion-item-options side="left">
        <button secondary (click)="unread(item)">Unread</button>
      </ion-item-options>
    </ion-item-sliding>

Ionic Version: 2.x

Fixes: #5073

[manucorporat]

Documentation is pending

[thomastthai]

How do I merge this pull request into my own branch? I'm very new to Git. Based on the doc from:

https://help.github.com/articles/checking-out-pull-requests-locally/

There should be a "Merge pull request" button at the bottom of this pull request, but I don't see it.

[manucorporat]

@thomastthai try this:

git checkout -b your_local_branch
git pull https://github.com/manucorporat/ionic.git  sliding-two-way

I use the --no-ff option (no fast forward), so you can then easily revert the merge by doing:

git reset --hard HEAD^

[ghenry22]

Nice work! Would be great to see this get merged, closes one more small gap to the native experience.

[adamdbradley]

Remove any commented code

[adamdbradley]

I don't think NgClass is needed here

[manucorporat]

new feature:

[manucorporat]

@adamdbradley @brandyscarney this is ready to be merged!

[dylanvdmerwe]

Hi @manucorporat

This is very cool. It definitely goes towards resolving my feature request: #6242