Skip to content

refactor(typography): add ion-text attribute selector, deprecate others#9096

Merged
adamdbradley merged 2 commits intomasterfrom
typography-refactor
Nov 10, 2016
Merged

refactor(typography): add ion-text attribute selector, deprecate others#9096
adamdbradley merged 2 commits intomasterfrom
typography-refactor

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Nov 9, 2016

  • Removes chained css from fab button
  • Adds :not([ion-fab]) to typography selector
  • Adds [ion-text] selector and adds deprecation warning for other selectors
  • Adds commented out docs for typography, should remove comment with selectors

closes #8293

@brandyscarney brandyscarney mentioned this pull request Nov 9, 2016
Closed
@brandyscarney brandyscarney modified the milestone: 2.0.0-rc.3 Nov 10, 2016
manucorporat
manucorporat approved these changes Nov 10, 2016
View reviewed changes
Copy link
Contributor

@manucorporat manucorporat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamdbradley adamdbradley merged commit ae1197a into master Nov 10, 2016
@brandyscarney brandyscarney deleted the typography-refactor branch November 14, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@manucorporat manucorporat manucorporat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

Anchors with ion-button and color are getting text and button color classes

3 participants

@brandyscarney @manucorporat @adamdbradley