Skip to content

Revision of qcscore_model_spe branch#65

Open
drighelli with Copilot wants to merge 4 commits into
qscore_model_spefrom
copilot/qcscore-model-spe
Open

Revision of qcscore_model_spe branch#65
drighelli with Copilot wants to merge 4 commits into
qscore_model_spefrom
copilot/qcscore-model-spe

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
  • Fixed some issues with QS computation with custom formula;
  • updated QC functions documentation;
  • added more customizable settings to plot functions;
  • function name standardization to Quality Score (QScore);
  • added backward-compatible deprecated wrappers for computeQCScore() and computeQCScoreFlags() following Bioconductor .Deprecated() guidelines;
  • updated vignettes.

Copilot AI changed the title [WIP] Revision of qcscore_model_spe branch Revision of qcscore_model_spe branch Jul 24, 2026
Copilot AI requested a review from drighelli July 24, 2026 10:13
@drighelli

Copy link
Copy Markdown
Owner

@copilot fix warning and note coming from workflows!
Check consistencies of the function arguments in the function code itself!

❯ checking Rd \usage sections ... WARNING
  Undocumented arguments in Rd file 'plotZoomFovsMap.Rd'
    ‘csize’ ‘calpha’
  
  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

❯ checking R code for possible problems ... NOTE
  computeQScore: no visible global function definition for ‘terms’
  Undefined global functions or variables:
    terms
  Consider adding
    importFrom("stats", "terms")
  to your NAMESPACE file.

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix warning and note coming from workflows!
Check consistencies of the function arguments in the function code itself!

...

Fixed both issues in commit Fix R CMD check WARNING and NOTE:

  1. WARNING (plotZoomFovsMap.Rd undocumented args): Removed the unused csize and calpha parameters from the plotZoomFovsMap function signature — they were never used in the function body (equivalent arguments can be passed via ... to plotPolygons if needed).

  2. NOTE (computeQScore: no visible global function definition for 'terms'): Added terms to the @importFrom stats line in QC.R and added importFrom(stats,terms) to NAMESPACE.

@BenedettaBanzi
BenedettaBanzi marked this pull request as ready for review July 24, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants