fix(release): stamp tag version and re-draft so v0.16.1 installers attach - #570
Conversation
workflow_run uses develop's Build & Publish YAML. Without a stamp, tag-without-bump packages as 0.15.2 and electron-builder skips upload onto the already-published v0.15.2. Re-draft the target release so a retry can attach dmg/exe/AppImage to v0.16.1. Co-authored-by: Tomás Maritano <tomymaritano@gmail.com>
|
Warning Review limit reached
Next review available in: 3 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Summary
Build & Publish #27 (run 32590544551) built signed mac/win/linux installers, then the run went red. v0.16.1 notes exist; assets were empty.
Job that made #27 red:
sync-develop/ Create sync PRTomás: Settings → Actions → General → Workflow permissions → enable Allow GitHub Actions to create and approve pull requests. That is not why binaries are missing.
Why assets were empty (all three
buildjobs +publishsucceeded):workflow_runuses develop's YAML (default branch), which lacked the stamp step already onmain. Tree version is still0.15.2(tag-without-bump). electron-builder packagedDripnex-0.15.2.*and skipped upload onto the already-publishedv0.15.2:Signing/notary is fine (
notarization successful;CSC_*/APPLE_*present). Not a flake.This PR (develop — the file
workflow_runactually runs):package.jsonfrom the tag before packaging (same step asmain/ fix(release): tag without pushing a bump commit to main #540).--publish alwayscan attach assets on retry.No product code. AuthGate untouched. No store. No iOS.
Retry (Tomás — cloud agent token cannot
workflow_dispatch, HTTP 403)v0.16.1 is already converted back to draft so electron-builder can upload. Either:
Actions UI: Run workflow → branch
mainorcursor/fix-v0161-build-assets-f239→ tagv0.16.1.sync-developwill fail again on the retry until the Actions PR setting above is enabled. Installers still attach before that job.Type of Change
Related Issues
Unblocks empty v0.16.1 assets after promotion #569 / Build #27.
Checklist
developbranch (notmain)