feat(theme): Harbor Dusk - #590
Conversation
Official dark palette for long evening writing sessions: deep navy-slate surfaces, mist text, muted teal chrome, amber lanterns on links. Co-authored-by: Tomás Maritano <tomymaritano@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds the first-party ChangesHarbor Dusk Theme
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds the Harbor Dusk theme and its registration tests without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Assert unique ids, whitelist tokens, and Harbor Dusk's teal/amber contract.
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
First daily official theme pack: Harbor Dusk (
dripnex-harbor-dusk). Coastal evening palette for long writing sessions — calm, low glare, readable markdown. Same contract as Parchment / Wave / Night / Fog: a token layer overtokens.css, registered inOFFICIAL_THEMES. No new fonts, no stylesheet fork, no plugin pack.Evening sibling to Fog (coastal gray morning). Merge needs a Dripnex / Tomás gate — draft only, do not merge from this PR.
Concept
Harbor after sunset: deep slate/navy water, mist over the docks, muted teal from the tide, warm amber from lanterns. Built for long markdown sessions, not OLED punch.
Palette preview
--bg-base#141c26--bg-surface#10161e--bg-elevated#1c2633--bg-inset#0c1218--text-primary#cdd6de--accent#5e9a92--accent-hover#74aea6--cm-link/--status-on-hold#d4a05a--status-completed#7aad8a--status-dropped#c46b6bHover, borders, and glass use mist at low opacity so chrome stays quiet. Typography is the existing
--font-sans/--font-monostack; this pack does not set font faces.--cm-linkis the one extra vs other official palettes (allowed--cm-*extension, same as the communitytheme.jsontemplate) so editor links read as lanterns while chrome stays teal. Preview markdown links still follow--accent—--linkis not in the theme whitelist.Files touched
apps/desktop/src/renderer/themes/officialThemes.ts— register Harbor Duskapps/desktop/src/renderer/themes/__tests__/officialThemes.test.ts— unique ids + token whitelist, including Harbor Duskdocs/themes/LOG.md— daily id/topic log (required so later packs do not reuse this id)No lockfile, no site listing, no marketplace registry (
theme-parchmentsatellite is a different shipping path).How to preview
pnpm dev(desktop)Restore Default (or another palette) to leave the session as you found it.
Type of Change
Checklist
develop(notmain)@dripnex/desktop325 tests)pnpm test/pnpm build(CI)Summary by CodeRabbit
New Features
Documentation
Tests