Skip to content

feat(theme): Harbor Dusk - #590

Merged
github-actions[bot] merged 2 commits into
developfrom
feature/theme-harbor-dusk
Aug 24, 2026
Merged

feat(theme): Harbor Dusk#590
github-actions[bot] merged 2 commits into
developfrom
feature/theme-harbor-dusk

Conversation

@tomymaritano

@tomymaritano tomymaritano commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

First daily official theme pack: Harbor Dusk (dripnex-harbor-dusk). Coastal evening palette for long writing sessions — calm, low glare, readable markdown. Same contract as Parchment / Wave / Night / Fog: a token layer over tokens.css, registered in OFFICIAL_THEMES. No new fonts, no stylesheet fork, no plugin pack.

Evening sibling to Fog (coastal gray morning). Merge needs a Dripnex / Tomás gate — draft only, do not merge from this PR.

Concept

Harbor after sunset: deep slate/navy water, mist over the docks, muted teal from the tide, warm amber from lanterns. Built for long markdown sessions, not OLED punch.

Palette preview

Role Token Hex
Canvas --bg-base #141c26
Sidebar --bg-surface #10161e
Raised chrome --bg-elevated #1c2633
Inset / code --bg-inset #0c1218
Mist text --text-primary #cdd6de
Teal accent --accent #5e9a92
Accent hover --accent-hover #74aea6
Amber lanterns (links, on-hold) --cm-link / --status-on-hold #d4a05a
Completed --status-completed #7aad8a
Dropped --status-dropped #c46b6b

Hover, borders, and glass use mist at low opacity so chrome stays quiet. Typography is the existing --font-sans / --font-mono stack; this pack does not set font faces.

--cm-link is the one extra vs other official palettes (allowed --cm-* extension, same as the community theme.json template) so editor links read as lanterns while chrome stays teal. Preview markdown links still follow --accent--link is not in the theme whitelist.

Files touched

  • apps/desktop/src/renderer/themes/officialThemes.ts — register Harbor Dusk
  • apps/desktop/src/renderer/themes/__tests__/officialThemes.test.ts — unique ids + token whitelist, including Harbor Dusk
  • docs/themes/LOG.md — daily id/topic log (required so later packs do not reuse this id)

No lockfile, no site listing, no marketplace registry (theme-parchment satellite is a different shipping path).

How to preview

  1. pnpm dev (desktop)
  2. Settings → Themes
  3. Select Harbor Dusk
  4. Check sidebar, note list, editor, command palette, and a markdown note with headings, links, lists, and a code block

Restore Default (or another palette) to leave the session as you found it.

Type of Change

  • New feature

Checklist

  • PR targets develop (not main)
  • Draft — merge needs Dripnex / Tomás gate
  • Official theme unit tests pass (@dripnex/desktop 325 tests)
  • Workspace typecheck passed on push
  • Full pnpm test / pnpm build (CI)
Open in Web Open in Cursor 

Summary by CodeRabbit

  • New Features

    • Added the official Harbor Dusk dark theme, featuring coastal evening colors, muted teal accents, amber status tones, frosted surfaces, and improved code-link styling.
  • Documentation

    • Added Harbor Dusk to the official theme log.
  • Tests

    • Added validation covering theme metadata, color schemes, token values, unique identifiers, and accent consistency.

Official dark palette for long evening writing sessions: deep navy-slate
surfaces, mist text, muted teal chrome, amber lanterns on links.

Co-authored-by:  Tomás Maritano <tomymaritano@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: da949a11-718b-4ffa-89d0-f998ae0810b1

📥 Commits

Reviewing files that changed from the base of the PR and between a9e94f7 and 625ccbe.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/themes/__tests__/officialThemes.test.ts
  • apps/desktop/src/renderer/themes/officialThemes.ts
  • docs/themes/LOG.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds the first-party dripnex-harbor-dusk dark theme, documents it in the theme log, and adds tests for official theme metadata, tokens, accent aliases, and Harbor Dusk values.

Changes

Harbor Dusk Theme

Layer / File(s) Summary
Register and document Harbor Dusk
apps/desktop/src/renderer/themes/officialThemes.ts, docs/themes/LOG.md
Adds the dripnex-harbor-dusk dark theme with coastal colors, teal accents, amber status tones, frosted-surface tokens, and a CodeMirror link token. Records the palette in the theme log.
Validate official theme definitions
apps/desktop/src/renderer/themes/__tests__/officialThemes.test.ts
Tests unique theme IDs, required metadata, valid schemes and tokens, accent aliases, and Harbor Dusk color values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 625cc

This PR adds the Harbor Dusk theme and its registration tests without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding the Harbor Dusk theme.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/theme-harbor-dusk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Assert unique ids, whitelist tokens, and Harbor Dusk's teal/amber contract.
@github-actions github-actions Bot added size/M and removed size/S labels Aug 24, 2026
@tomymaritano
tomymaritano marked this pull request as ready for review August 24, 2026 13:11
@github-actions
github-actions Bot enabled auto-merge (squash) August 24, 2026 13:11
@github-actions
github-actions Bot merged commit f9f0b48 into develop Aug 24, 2026
22 of 24 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants