fix(drizzle-orm): fix configuration validation correct property checks for schema and casing #4230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Important❗️❗️❗️
Change Summary:
I fixed two typo bugs in the configuration validation logic where the
'schema'and'casing'configuration properties were being incorrectly validated by checking the wrong property (data['logger']instead ofdata['schema']anddata['casing']).Why This Matters:
Schema Validation Fix:
typeof data['logger']when validating the'schema'property.typeof data['schema']to validate the schema configuration.Casing Validation Fix:
typeof data['logger']when validating the'casing'property.typeof data['casing']to validate the casing configuration.Impact:
schemaandcasingsettings.This change addresses a subtle but critical validation oversight, ensuring the configuration checker accurately reflects the intended structure of the configuration object. It improves code correctness and reliability for schema and casing configuration handling.