fix(progress-viewer): enable cancellation while loading (#339, re-landing PR #342 onto main)#373
Open
drmoisan wants to merge 7 commits into
Open
fix(progress-viewer): enable cancellation while loading (#339, re-landing PR #342 onto main)#373drmoisan wants to merge 7 commits into
drmoisan wants to merge 7 commits into
Conversation
- Enable the Cancel button when a cancellation source is assigned - Verify button selection cancels the same source with an MSTest regression - Record acceptance criteria and QA evidence for the fix Refs: #339
- Add code, feature, and policy audits with a bounded remediation plan - Normalize six TRX whitespace findings while preserving test counters - Record final scope, integrity, diff-check, and readiness evidence Refs: #339
- Add post-remediation code, feature, and policy audits - Confirm acceptance, coverage, and branch-integrity gates pass - Record readiness for PR creation and CI verification Refs: #339
…on-339 Enable ProgressViewer cancellation during loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(progress-viewer): enable cancellation while loading (#339, re-landing PR #342 onto main)
Summary
main. PR Enable ProgressViewer cancellation during loading #342 delivered this work but was merged intobump-releaseinstead ofmain, so the fix never reached the default branch; issue Bug: progress-viewer-cancel-button #339 remains open.UtilitiesCS/Threading/ProgressViewer.cs(6 changed lines) enables the Cancel button and wires it to the assignedCancellationTokenSourcewhile loading.UtilitiesCS.Test/Threading/ProgressViewer_Tests.cs(+108 lines), includingCancelSource_WhenAssigned_EnablesButtonAndCancelsSameSourceOnClick, which failed before the fix and passes after.docs/features/active/2026-07-16-progress-viewer-cancel-button-339/): plan, audits, remediation records, and QA/coverage evidence (52 docs/evidence files, including two large Cobertura XML baselines and a TRX).bump-releasehead (429fcae) opened againstmain; no new commits were authored. The merge with currentmainwas verified conflict-free (git merge-tree).Why
During the 2026-07-18 worktree/branch cleanup,
git cherry origin/mainshowed the fix commit (a22530c) has no equivalent onmain, and issue #339 is still open: PR #342's base branch wasbump-release, which was itself never re-merged intomain. Openingbump-releaseagainstmainre-lands the stranded work without rewriting history.What Changed
UtilitiesCS/Threading/ProgressViewer.cs— cancellation enabled during loading (6 changed lines)UtilitiesCS.Test/Threading/ProgressViewer_Tests.cs— new cancellation regression testsdocs/features/active/2026-07-16-progress-viewer-cancel-button-339/):Note: the PR-context overview classifies all changes as docs; the actual diff contains the two C# files listed above (verified via
git diff origin/main...HEAD -- "*.cs").Architecture / How It Fits Together
ProgressViewer(UtilitiesCS threading UI helper) exposes aCancelSource; the fix enables the Cancel button when a source is assigned and cancels that same source on click. No public API surface changes beyond this behavior.Verification
bump-releasehead):fail-before-339, exit 1 expected) and passed after (pass-after-339, exit 0).dotnet tool run csharpier format .— passmsbuild TaskMaster.sln /t:Build /p:EnableNETAnalyzers=true /p:EnforceCodeStyleInBuild=true— passmsbuild TaskMaster.sln /t:Build /p:Nullable=enable /p:TreatWarningsAsErrors=true— passfailrow,p2-t4-plan-revision-request, is the remediation trigger that was subsequently resolved; final audits show blocking count 0)Format, build, analyze, and testcheck before merging.Backward Compatibility / Migration Notes
None. Behavioral fix plus additive tests and documentation.
Risks and Mitigations
mainchanges (breadcrumb epic, dependency bumps). Mitigation: merge verified conflict-free; PR CI rebuilds and retests the merged tree.Review Guide
UtilitiesCS/Threading/ProgressViewer.cs— the entire behavioral change (6 lines).UtilitiesCS.Test/Threading/ProgressViewer_Tests.cs— regression tests.policy-audit,code-review,feature-audit, timestamps2026-07-16T16-18/2026-07-16T17-02) — review outcomes.Follow-ups
origin/bump-releaseandorigin/bug/progress-viewer-cancel-button-339become fully merged and can be deleted.docs/features/active/per the promotion lifecycle when the issue closes.GitHub Auto-close