gui: fixes a forever loop when a malformed interface is specified#96
Merged
tridge merged 1 commit intodronecan:masterfrom Mar 25, 2026
Conversation
If you used an argument that results in the device failing to open, it falls through to Exception. If the exception occurs, you can result in a forever loop where the interface was set at the command line, but the device fails to open. If an exception occurs, force a return to the setup window, with cleared iface and args.
tridge
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you used an argument that results in the device failing to open (eg
--interface aaaa), it falls through toException.If the exception occurs, you can result in a forever loop where a non-serial interface was set at the command line, but the device fails to open.
If an exception occurs, force a return to the setup window, with cleared iface and args.