-
Notifications
You must be signed in to change notification settings - Fork 248
add magic number for emergency disarm #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squilter No need to add a corresponding method in the Drone
class. Their uses are being deprecated (the deprecated
javadocs should be in latest from develop
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not using the emergencyDisarm
value here.
076849f
to
0197d5a
Compare
once this is done, we can fix DroidPlanner/Tower#1494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squilter since the original method signature is still available, this change can be reverted.
b443e33
to
5507d0d
Compare
@squilter looks good to merge. are you still doing tests? |
@ne0fhyk I can't figure out how to test anything. I can't figure out how to import the compiled aar into the Tower project, so I can't actually test this on a copter. |
In the gradle build file for tower, there are a couple of dependencies that You can follow the same format to load the dronekit aar file. The file Fredia Huya-Kouadio
|
Got it. Yes, it works. |
Great, merging! |
add magic number for emergency disarm
This adds a new feature for AC3.3 which Randy explains at ArduPilot/ardupilot#2353. It sends a special command which disarms a vehicle immediately, even if it is still flying.
Don't merge yet. Still needs testing.