Reorder instructions in quickstart guide #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@peterbarker I prefer the original order - works perfectly on Windows. Windows is for Winners. Linux is for ... |
Contributor
|
But not enough to block it if you feel strongly .... |
Contributor
Author
|
User testing is priceless. And he was working on Mac, so considered a neutral third party :-P |
Contributor
|
Fair enough. Lets see if you can get the tests to pass :-) |
peterbarker
force-pushed
the
reorder-quickstart
branch
2 times, most recently
from
5049d19 to
a5b4b0d
Compare
Contributor
Author
|
@hamishwillee In the words of a wise man; 2 out-of-3 aint bad. AppVeyor is no longer "Required", and I don't think this could reasonably affect anything it tests... |
Contributor
|
@peterbarker Agree but
|
peterbarker
force-pushed
the
reorder-quickstart
branch
from
a5b4b0d to
34b9267
Compare
Contributor
|
@peterbarker Rebase? |
peterbarker
force-pushed
the
reorder-quickstart
branch
from
34b9267 to
1c9b696
Compare
Member
|
@peterbarker we need to merge this, if you have time can you rebase so I can merge? |
peterbarker
force-pushed
the
reorder-quickstart
branch
from
41bc6c6 to
9c150a2
Compare
Contributor
Author
|
On Tue, 12 Apr 2016, Ramon Roche wrote:
@peterbarker we need to merge this, if you have time can you rebase so I can
merge?
Rebased.
|
Contributor
|
Thanks @peterbarker - LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.