Skip to content

Conversation

@chris-mitchell
Copy link
Contributor

The pathsAffectedAllBuilds will only look at unknown files to trigger the build, this changed it to look at any of the changed files.

#64

@chris-mitchell chris-mitchell requested a review from wclausen July 26, 2021 17:08
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #65 (a7984d9) into main (4b621d0) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
+ Coverage     49.08%   49.31%   +0.23%     
  Complexity       47       47              
============================================
  Files            12       12              
  Lines           436      438       +2     
  Branches         97       97              
============================================
+ Hits            214      216       +2     
  Misses          192      192              
  Partials         30       30              
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 40.22% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b621d0...a7984d9. Read the comment docs.

Copy link

@wclausen wclausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff fixes an issue where changed files that affect all modules were not triggering builds/tests for all the modules.

Previously, we only checked for "should we build all modules" for files that we couldn't map to a containing project (aka "unknownFiles").

Note, unknownFiles will always be a subset of changedFiles based on how those variables are populated.

@chris-mitchell chris-mitchell merged commit 2aa1d0f into dropbox:main Jul 26, 2021
@chris-mitchell chris-mitchell deleted the fixIssue64 branch July 26, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants