Skip to content

Ensure pathsAffectingAllBuilds will include any changed files #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Ensure pathsAffectingAllBuilds will include any changed files #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...duledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ class AffectedModuleDetectorImpl constructor(
findDependentProjects()
}

private var changedFiles: MutableSet<String> = mutableSetOf()

private var unknownFiles: MutableSet<String> = mutableSetOf()

override fun shouldInclude(project: Project): Boolean {
Expand Down Expand Up @@ -400,8 +402,10 @@ class AffectedModuleDetectorImpl constructor(
* Also populates the unknownFiles var which is used in findAffectedProjects
*/
private fun findChangedProjects(): Set<Project> {
val changedFiles = git.findChangedFiles(
includeUncommitted = true
changedFiles.addAll(
git.findChangedFiles(
includeUncommitted = true
)
)

val changedProjects = mutableSetOf<Project>()
Expand Down Expand Up @@ -462,7 +466,7 @@ class AffectedModuleDetectorImpl constructor(
if (changedProjects.isEmpty() && unknownFiles.isEmpty()) {
buildAll = true
}
unknownFiles.forEach {
changedFiles.forEach {
if (affectsAllModules(it)) {
buildAll = true
}
Expand Down