js_client: add optional request options parameter - #387
Merged
Conversation
cguldner
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds an opt-in --request-options flag to the JavaScript client backend.
When enabled, generated client methods:
For example:
The generated output is unchanged unless --request-options is explicitly enabled.
Motivation
Some SDKs need per-request transport options that are separate from API request arguments, such as request cancellation (AbortSignal), request timeouts, or future transport-specific behavior.
This change provides a generic mechanism for JavaScript client generators to expose those options without changing generated API request types.