feat: Starknet family support (starknet, starknet-sepolia)#293
Merged
Conversation
* docs: starknet family support design spec * docs: mark starknet design approved * feat(starknet): full family support Fixes the half-registered state where a starknet upstream died with "no method spec with name ''" - the BlockchainType existed but nothing else. - starknet_specific: poll-based latest head via getBlockWithTxHashes (dshackle parity), poll-only (spec-v0.8 WS is a follow-up). - starknet_validations: real chain-id validation via starknet_chainId (dshackle hardcodes the response and validates nothing) and syncing health handling all three result forms (false/true/sync object, hex or numeric block fields, lag threshold). - starknet_labels: two-probe client identity (pathfinder_version -> juno_version fallback) as a direct LabelsDetector implementation. - starknet_bounds: verified-archive bound - probes block 1 and emits STATE/BLOCK=1 only on success (dshackle hardcodes 1 blindly); pruned nodes fall back to UnknownBound with a logged follow-up. - starknet method spec: the 25-method dshackle-parity surface, not-null dispatch on block/tx reads and the three add*Transaction submits - NOT broadcast: starknet returns DUPLICATE_TX=59 on identical resubmission, fan-out would manufacture errors (the very reason dshackle's broadcast is broken there). - registry: getMethodSpecName starknet case + factory case. * docs: record live validation results for starknet family * docs: starknet family docs (README, upstream-config, method-specs) + self-contained spec wording * docs: add starknet rows to the validators table * review: starknet - l1_accepted finality, constant lower bound, no ws caps - GetFinalizedBlock now polls the l1_accepted tag (RPC spec >= 0.9): latest is only ACCEPTED_ON_L2, L1 acceptance lags it by hours (verified on juno v0.16.4: latest=12262080 vs l1_accepted=12259300 on sepolia) - block processor is wired to poll the finalized head (safe disabled) - CapDetectors returns nil: no ws transport in v1 scope - lower bound simplified to dshackle parity: constant 1, juno/pathfinder keep full block history so there is nothing to calculate - empty chain id is now FatalSettingError - tests for StarknetChainSpecificObject * review: starknet - rename health validator to syncing validator, gate by ValidateSyncing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #285 onto main: the original PR was stacked on the ripple branch (#284) and got squashed into it by mistake. This is the same approved starknet diff, cherry-picked onto main with the ripple-only context stripped.