Skip to content

feat: add Intercom destination - #351

Merged
masukai merged 3 commits into
drt-hub:mainfrom
PFCAaron12:feat/add-Intercom-destination
Apr 16, 2026
Merged

feat: add Intercom destination#351
masukai merged 3 commits into
drt-hub:mainfrom
PFCAaron12:feat/add-Intercom-destination

Conversation

@PFCAaron12

Copy link
Copy Markdown
Collaborator

What does this PR do?

  1. drt/destinations/intercom.py — Intercom REST API v2 integration

  2. Create/update contacts via bearer token auth

  3. Jinja2 template for contact attributes

  4. Unit tests

  5. Added to drt/cli/main.py

Related Issue

Closes # 163

Checklist

  • Tests pass (make test)
  • Linter passes (make lint)
  • Updated CHANGELOG.md (if user-facing change)

masukai
masukai previously approved these changes Apr 16, 2026

@masukai masukai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Solid Intercom integration — properties_template for flexible contact attribute mapping and clean error handling per row. Nice work!

I pushed a small fix for ruff lint + mypy type narrowing (BearerAuth assert) — no action needed from your side.

Thanks for the contributions @PFCAaron12! If you're looking for more to work on, check out our good first issues:
https://github.com/drt-hub/drt/issues?q=is%3Aopen+label%3A%22good+first+issue%22

@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
drt/destinations/intercom.py 94.00% 3 Missing ⚠️
drt/config/models.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@masukai
masukai merged commit 7cc9a07 into drt-hub:main Apr 16, 2026
5 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants