Skip to content

Suggest to install Drupal Console - #353

Closed
pfrenssen wants to merge 3 commits into
drupal-composer:8.xfrom
pfrenssen:suggest-drupal-console
Closed

Suggest to install Drupal Console#353
pfrenssen wants to merge 3 commits into
drupal-composer:8.xfrom
pfrenssen:suggest-drupal-console

Conversation

@pfrenssen

Copy link
Copy Markdown
Collaborator

Fixes #352.

@FatherShawn

FatherShawn commented Feb 15, 2018

Copy link
Copy Markdown

I don't think project itself uses/requires drush either. If we move this should we not be consistent and suggest Drush as well? That said I can't picture setting up a drupal site as CLI administered via Composer without including the other CLI tools for Drupal.

@gnuget

gnuget commented Feb 15, 2018

Copy link
Copy Markdown

I agree with @FatherShawn, maybe we can include a fix to #357 on this PR?

@pfrenssen

Copy link
Copy Markdown
Collaborator Author

Good suggestion, Drush is only used in the test suite, so it can be moved to require-dev.

@weitzman

weitzman commented Feb 16, 2018 via email

Copy link
Copy Markdown
Contributor

@jackbravo

Copy link
Copy Markdown

I agree with moshe that drush is often used in production environments, although for the purist that is also wrong, but we are talking of things people use, not about some gold standard. For the same reason, moving drupal console to suggested seems backwards to me, maybe, just maybe require-dev would be fine instead of require, and that is just while drush 8 is still being used. I'm not sure right now which one of drush 9 or drupal console I would use more routinely in production, probably console, so I would leave both in require.

@pfrenssen

Copy link
Copy Markdown
Collaborator Author

In the issue there were a lot of people commenting that they are interested in having it available for development by default. Let's move it to require-dev. I agree that Drush is probably best kept in require since most Drupal sites need it in production.

@webflo

webflo commented Jun 26, 2018

Copy link
Copy Markdown
Member

I will keep it as is for now. This could be a feature of the setup wizard. #384

@webflo webflo closed this Jun 26, 2018
@pfrenssen
pfrenssen deleted the suggest-drupal-console branch June 27, 2018 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants