Skip to content

fix(travis): Install missing mysql#920

Merged
fubhy merged 2 commits intodrupal-graphql:8.x-4.xfrom
klausi:fix-travis
Oct 14, 2019
Merged

fix(travis): Install missing mysql#920
fubhy merged 2 commits intodrupal-graphql:8.x-4.xfrom
klausi:fix-travis

Conversation

@klausi
Copy link
Copy Markdown
Contributor

@klausi klausi commented Oct 14, 2019

Try to get Travis CI running again.

@klausi
Copy link
Copy Markdown
Contributor Author

klausi commented Oct 14, 2019

Hopefully this fixes the test fail. I found a security issue where we use $accessResult->isForbidden() which does not do what you think it does. We always need to use $accessResult->isAllowed() to check for access.

@fubhy fubhy merged commit d086b8b into drupal-graphql:8.x-4.x Oct 14, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (8.x-4.x@0bf46bc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             8.x-4.x     #920   +/-   ##
==========================================
  Coverage           ?   66.43%           
  Complexity         ?      587           
==========================================
  Files              ?       92           
  Lines              ?     1299           
  Branches           ?        0           
==========================================
  Hits               ?      863           
  Misses             ?      436           
  Partials           ?        0
Impacted Files Coverage Δ Complexity Δ
...GraphQL/DataProducer/Entity/EntityLoadMultiple.php 66.66% <100%> (ø) 23 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf46bc...15f4f66. Read the comment docs.

@rthideaway rthideaway mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants