Fix access checking.#921
Merged
fubhy merged 1 commit intodrupal-graphql:8.x-4.xfrom Oct 14, 2019
Merged
Conversation
Contributor
Author
|
@fubhy please check, these are all instances with incorrect access checking. I'm going to fix our PRs as well |
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #921 +/- ##
==========================================
Coverage 66.43% 66.43%
Complexity 587 587
==========================================
Files 92 92
Lines 1299 1299
==========================================
Hits 863 863
Misses 436 436
Continue to review full report at Codecov.
|
Contributor
|
Sweet, thanks! |
Contributor
|
I think we should have a code comment for all those checks similar as in #920 , otherwise someone might change this back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing access checking as we recently discovered it was misimplemented, see #920 (comment)