This repository was archived by the owner on Jan 5, 2018. It is now read-only.
Check whether the specified entity_type exists before trying to embed entity.#10
Closed
cs-shadow wants to merge 4 commits into
Closed
Check whether the specified entity_type exists before trying to embed entity.#10cs-shadow wants to merge 4 commits into
cs-shadow wants to merge 4 commits into
Conversation
Member
|
I think it would probably be better to wrap all the entity loading and rendering using a |
Member
There was a problem hiding this comment.
This belongs to another PR. You should separate things.
Member
There was a problem hiding this comment.
Yeah, it looks like you're creating new PRs from existing PR branches, which makes things difficult to review. It would help to always create new branches/PRs from 8.x-1.x.
Member
Author
There was a problem hiding this comment.
My bad. Remnant of previous PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in drupal.org issue: https://drupal.org/node/2271185.
Should be merged after PR #9 passes through.