Skip to content
This repository was archived by the owner on Jan 5, 2018. It is now read-only.

Remove all children of the node from the existing DOMDocument.#9

Merged
davereid merged 2 commits into
drupal-media:8.x-1.xfrom
cs-shadow:8.x-1.x
May 20, 2014
Merged

Remove all children of the node from the existing DOMDocument.#9
davereid merged 2 commits into
drupal-media:8.x-1.xfrom
cs-shadow:8.x-1.x

Conversation

@cs-shadow
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does hasChildNodes() return anything other than a boolean? If not, we can just skip the == TRUE part.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed returns only boolean values. I'll remove the ==TRUE part in next commit, once I'm done with the tests for this.

davereid added a commit that referenced this pull request May 20, 2014
Remove all children of the entity's embed code DOMNode when doing the embedding.
@davereid davereid merged commit 4337fa9 into drupal-media:8.x-1.x May 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants